OCM-9139 | fix: Enable maxSurge and maxUnavailable for interactive mode

openshift · Jul 11, 2024 · 0e15183 · 0e15183
1 parent 0579b2b
commit 0e15183
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cmd/create/machinepool/nodepool.go b/cmd/create/machinepool/nodepool.go
@@ -474,7 +474,7 @@ func addNodePool(cmd *cobra.Command, clusterKey string, cluster *cmv1.Cluster, r
 
 	isMaxSurgeSet := cmd.Flags().Changed("max-surge")
 	isMaxUnavailableSet := cmd.Flags().Changed("max-unavailable")
-	if isMaxSurgeSet && isMaxUnavailableSet {
+	if isMaxSurgeSet || isMaxUnavailableSet || interactive.Enabled() {
 		maxSurge := args.maxSurge
 		if interactive.Enabled() {
 			maxSurge, err = interactive.GetString(interactive.Input{

diff --git a/pkg/machinepool/machinepool.go b/pkg/machinepool/machinepool.go
@@ -779,7 +779,7 @@ func editNodePool(cmd *cobra.Command, nodePoolID string,
 		}
 	}
 
-	if isUpgradeMaxSurgeSet && isUpgradeMaxUnavailableSet {
+	if isUpgradeMaxSurgeSet || isUpgradeMaxUnavailableSet || interactive.Enabled() {
 		maxSurge := cmd.Flags().Lookup("max-surge").Value.String()
 		if maxSurge == "" && nodePool.ManagementUpgrade().MaxSurge() != "" {
 			maxSurge = nodePool.ManagementUpgrade().MaxSurge()