OCM-9140 | fix: Do not enable interactive for max-surge and max-avail…

…able
openshift · Jun 26, 2024 · 07f74d0 · 07f74d0
1 parent 9cd807c
commit 07f74d0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/cmd/edit/machinepool/nodepool.go b/cmd/edit/machinepool/nodepool.go
@@ -36,7 +36,7 @@ func editNodePool(cmd *cobra.Command, nodePoolID string,
 
 	// isAnyAdditionalParameterSet is true if at least one parameter not related to replicas and autoscaling is set
 	isAnyAdditionalParameterSet := isLabelsSet || isTaintsSet || isAutorepairSet || isTuningsConfigSet ||
-		isKubeletConfigSet
+		isKubeletConfigSet || isUpgradeMaxSurgeSet || isUpgradeMaxUnavailableSet
 	isAnyParameterSet := isMinReplicasSet || isMaxReplicasSet || isReplicasSet ||
 		isAutoscalingSet || isAnyAdditionalParameterSet
 
@@ -225,7 +225,7 @@ func editNodePool(cmd *cobra.Command, nodePoolID string,
 		}
 	}
 
-	if isUpgradeMaxSurgeSet && isUpgradeMaxUnavailableSet && interactive.Enabled() {
+	if isUpgradeMaxSurgeSet && isUpgradeMaxUnavailableSet {
 		maxSurge := args.maxSurge
 		if maxSurge == "" && nodePool.ManagementUpgrade().MaxSurge() != "" {
 			maxSurge = nodePool.ManagementUpgrade().MaxSurge()