This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Bug 952047 - SSH key doesn't detect duplicate because name is changed #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
key.name is being passed to a formatting function which is appending a value to it. Prevent strings from being mutated by formatting.
|
@liggitt review |
|
Reviewed, [merge] |
|
Origin Test Results: SUCCESS (https://originci-openshift.rhcloud.com/job/test_pull_requests/975/) |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/2370/) (Image: devenv_3102) |
|
[Test]ing while waiting on the merge queue |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/1919/) |
|
Evaluated for online up to 7eb731d |
|
Evaluated for origin up to 7eb731d |
openshift-bot
pushed a commit
that referenced
this pull request
Apr 15, 2013
…_string Merged by openshift-bot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
key.name is being passed to a formatting function which is appending a value
to it. Prevent strings from being mutated by formatting.