Run domain setup and config setup during app create #357
Conversation
… setting up the base config, domain, and keys. Changes behavior of argument parsing for app to be optional.
|
@fabianofranz review please. Adds support for arbitrary argument separators and optional command line params (that's what the changes in command_runner and commands.rb are) |
|
[test] |
|
Origin Test Results: SUCCESS (https://originci-openshift.rhcloud.com/job/test_pull_requests/970/) |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/1915/) |
| rest_client.delete_key(name) | ||
| results { say "SSH key '#{name}' has been removed" } | ||
|
|
||
| success "removed" | ||
|
|
There was a problem hiding this comment.
We could eventually review this "template" of message everywhere, sometimes I think we lack on having a list of "standards" for CLI messages. For example, what is our default to tell users the command:
- succeeded (Success! || success || done || action verb in simple past)
- failed (Error! || error || exited with status n || ZOMG etc)
- or, in this specific case: "I will start doing something while you wait a moment... [input wait for a moment] done." (with line break, without line break, upper|lowercase, etc.
There was a problem hiding this comment.
Generally I've been trying to have folks apply "success ''" as the response. 'done' is the generic verb. Agree that we should be more consistent.
|
Looking good to [merge] but apparently needs manual merging. @smarterclayton please check. |
Conflicts: lib/rhc/wizard.rb
|
Evaluated for online up to 246de9a |
|
Evaluated for origin up to 246de9a |
Run domain setup and config setup during app create
|
Will be in devenv_3101 |
... unless the user has already configured those, or is in non-interactive mode.
will check for config, then run the non-key, non-test parts of the setup wizard (namespace, server, username, access token). If the user doesn't have a domain, we'll start the new DomainWizard to handle that step. Also, SSH keys will be run earlier in the flow (prior to DNS) so that users know to configure things properly.