-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create machineconfig for m5d #8102
Create machineconfig for m5d #8102
Conversation
70e986d
to
9dd0316
Compare
clusters/build-clusters/01_cluster/_machine_config/m5d_machineconfig.yaml
Outdated
Show resolved
Hide resolved
clusters/build-clusters/01_cluster/_machine_config/m5d_machineconfig.yaml
Outdated
Show resolved
Hide resolved
clusters/build-clusters/01_cluster/_machine_config/m5d_machineconfig.yaml
Outdated
Show resolved
Hide resolved
@hongkailiu can you just try out if it works by manually applying (and figure out first how to make the resulting nodes tainted so no test workloads end up on it)? |
9dd0316
to
83011a2
Compare
I will go through the review before i apply to it. |
clusters/build-clusters/01_cluster/_machine_config/m5d_machineconfig.yaml
Outdated
Show resolved
Hide resolved
5cb2573
to
7fed763
Compare
303745c
to
cbbadfc
Compare
If the Ignition config fails, the nodes won't join the cluster at all. (But, I guess it's possible to have the config silently do the wrong thing, so it is worth doing with a machineset of size 1 indeed) |
cbbadfc
to
ee2b442
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongkailiu, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ref [1] and [2].
[1]. https://docs.google.com/document/d/1G5Bw2J1vz8ff6n3Z6LCQmpReC3tHYTvMrUF9YgCClH4/edit#
[2]. https://github.com/cgwalters/playground/blob/d72d980b66cc2cb84e658140e5a7406691457aad/ignition/rhcos-raid-containers.json
Will remove
_
prefix of the folder after review