-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating MCO Job for OCL E2E Testing with OpenShift Upgrade #58241
Conversation
...rator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
Outdated
Show resolved
Hide resolved
...rator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
Outdated
Show resolved
Hide resolved
/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb |
@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
...rator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
Outdated
Show resolved
Hide resolved
...rator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
Outdated
Show resolved
Hide resolved
...rator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
Show resolved
Hide resolved
...rator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
Outdated
Show resolved
Hide resolved
/retest-required |
/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-techpreview |
@RishabhSaini: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-techpreview |
@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@cheesesashimi: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-conformance-suite-techpreview |
@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Based on the logs of the failing jobs, the daemons appear to recreate themselves frequently. I don't see any explicit errors, nor any weirdness in the operator or controller logs. The only thing is the daemonsets have very high |
This should have been fixed by: openshift/machine-config-operator#4691 |
/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-conformance-suite-techpreview |
@RishabhSaini: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@RishabhSaini: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-conformance-suite-techpreview |
@RishabhSaini: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@cheesesashimi: job(s): pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb either don't exist or were not found to be affected, and cannot be rehearsed |
/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-conformance-suite-techpreview pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-techpreview |
@RishabhSaini: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-conformance-suite-techpreview pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-techpreview |
@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-conformance-suite-techpreview pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-techpreview |
@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-conformance-suite-techpreview pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-techpreview |
@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor change and I think we can land this PR. Nice work on all of this!
...rator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
Outdated
Show resolved
Hide resolved
@@ -78,10 +78,14 @@ images: | |||
ostree container commit | |||
from: ocp_os | |||
to: custom-os-image | |||
- dockerfile_literal: | | |||
FROM quay.io/zzlotnik/zacks-openshift-helpers:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought (non-blocking): Once openshift/machine-config-operator#4718 lands, we'll need to tweak this job slightly to build the tools from the MCO repository instead of pulling them from this container image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
ea8b79d
to
838c1ae
Compare
@RishabhSaini,
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
OpenShift update while OCL is enabled and rolled out to a node openshift-machine-config-operator-master-presubmits: Configuring the job Co-authored-by: Rishabh Saini <[email protected]> Co-authored-by: Zack Zlotnik <[email protected]>
[REHEARSALNOTIFIER]
A total of 60 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-ocb-techpreview pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-techpreview |
@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse ack |
@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheesesashimi, RishabhSaini, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
33b7f9f
into
openshift:master
@RishabhSaini: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…shift#58241) OpenShift update while OCL is enabled and rolled out to a node openshift-machine-config-operator-master-presubmits: Configuring the job Co-authored-by: Zack Zlotnik <[email protected]>
…shift#58241) OpenShift update while OCL is enabled and rolled out to a node openshift-machine-config-operator-master-presubmits: Configuring the job Co-authored-by: Zack Zlotnik <[email protected]>
…shift#58241) OpenShift update while OCL is enabled and rolled out to a node openshift-machine-config-operator-master-presubmits: Configuring the job Co-authored-by: Zack Zlotnik <[email protected]>
Setup an e2e test for OpenShift update while OCL is enabled and rolled out to a node