Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating MCO Job for OCL E2E Testing with OpenShift Upgrade #58241

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

RishabhSaini
Copy link
Contributor

Setup an e2e test for OpenShift update while OCL is enabled and rolled out to a node

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@cheesesashimi
Copy link
Member

/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb

@openshift-ci-robot
Copy link
Contributor

@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RishabhSaini
Copy link
Contributor Author

/retest-required

@RishabhSaini
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-techpreview

@openshift-ci-robot
Copy link
Contributor

@RishabhSaini: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cheesesashimi
Copy link
Member

/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-techpreview
/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb

@openshift-ci-robot
Copy link
Contributor

@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@cheesesashimi: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

@cheesesashimi
Copy link
Member

/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-conformance-suite-techpreview

@openshift-ci-robot
Copy link
Contributor

@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@yuqi-zhang
Copy link
Contributor

Based on the logs of the failing jobs, the daemons appear to recreate themselves frequently. I don't see any explicit errors, nor any weirdness in the operator or controller logs. The only thing is the daemonsets have very high generation, which I'm not sure why that's happening at a glance.

@RishabhSaini
Copy link
Contributor Author

Based on the logs of the failing jobs, the daemons appear to recreate themselves frequently. I don't see any explicit errors, nor any weirdness in the operator or controller logs. The only thing is the daemonsets have very high generation, which I'm not sure why that's happening at a glance.

This should have been fixed by: openshift/machine-config-operator#4691

@RishabhSaini
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-conformance-suite-techpreview
/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-techpreview

@openshift-ci-robot
Copy link
Contributor

@RishabhSaini: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@RishabhSaini: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

@RishabhSaini
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-conformance-suite-techpreview

@openshift-ci-robot
Copy link
Contributor

@RishabhSaini: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@cheesesashimi: job(s): pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb either don't exist or were not found to be affected, and cannot be rehearsed

@RishabhSaini
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-conformance-suite-techpreview pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-techpreview

@openshift-ci-robot
Copy link
Contributor

@RishabhSaini: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cheesesashimi
Copy link
Member

/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-conformance-suite-techpreview pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-techpreview

@openshift-ci-robot
Copy link
Contributor

@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cheesesashimi
Copy link
Member

/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-conformance-suite-techpreview pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-techpreview

@openshift-ci-robot
Copy link
Contributor

@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cheesesashimi
Copy link
Member

/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-conformance-suite-techpreview pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-techpreview

@openshift-ci-robot
Copy link
Contributor

@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Member

@cheesesashimi cheesesashimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change and I think we can land this PR. Nice work on all of this!

@@ -78,10 +78,14 @@ images:
ostree container commit
from: ocp_os
to: custom-os-image
- dockerfile_literal: |
FROM quay.io/zzlotnik/zacks-openshift-helpers:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought (non-blocking): Once openshift/machine-config-operator#4718 lands, we'll need to tweak this job slightly to build the tools from the MCO repository instead of pulling them from this container image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@RishabhSaini RishabhSaini force-pushed the ocl branch 2 times, most recently from ea8b79d to 838c1ae Compare December 11, 2024 15:46
@openshift-ci-robot
Copy link
Contributor

@RishabhSaini, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: [jobs pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade and pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-ocb-techpreview report to the same GitHub context "ci/prow/e2e-aws-ovn-ocb-techpreview", jobs pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-ocb-techpreview and pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade report to the same GitHub context "ci/prow/e2e-aws-ovn-ocb-techpreview", duplicated presubmit jobs (consider both inrepo and central config): [pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade]]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

OpenShift update while OCL is enabled and rolled out to a node
openshift-machine-config-operator-master-presubmits: Configuring the job

Co-authored-by: Rishabh Saini <[email protected]>
Co-authored-by: Zack Zlotnik <[email protected]>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@RishabhSaini: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-ocb-techpreview openshift/machine-config-operator presubmit Presubmit changed
pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-techpreview openshift/machine-config-operator presubmit Presubmit changed
pull-ci-openshift-machine-config-operator-master-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-4.12-upgrade-from-stable-4.11-images openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-bootstrap-unit openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-cluster-bootimages openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-agent-compact-ipv4 openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-aws-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-fips openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-fips-op openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-out-of-change openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-workers-rhel8 openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-aws-proxy openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-aws-serial openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-aws-single-node openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-aws-upgrade-single-node openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-aws-workers-rhel8 openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-azure openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-azure-ovn-upgrade openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-azure-ovn-upgrade-out-of-change openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-azure-upgrade openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-gcp-op openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-master-e2e-gcp-op-single-node openshift/machine-config-operator presubmit Ci-operator config changed

A total of 60 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@cheesesashimi
Copy link
Member

/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-ocb-techpreview pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-techpreview

@openshift-ci-robot
Copy link
Contributor

@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cheesesashimi
Copy link
Member

/pj-rehearse ack
/lgtm
/approve

@openshift-ci-robot
Copy link
Contributor

@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 11, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, RishabhSaini, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 33b7f9f into openshift:master Dec 11, 2024
14 of 17 checks passed
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@RishabhSaini: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-ovn-upgrade-ocb ec175a4 link unknown /pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-ovn-upgrade-ocb-conformance-suite-techpreview f46a44f link unknown /pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-ocb-conformance-suite-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

yingzhanredhat pushed a commit to yingzhanredhat/release that referenced this pull request Dec 18, 2024
…shift#58241)

OpenShift update while OCL is enabled and rolled out to a node
openshift-machine-config-operator-master-presubmits: Configuring the job

Co-authored-by: Zack Zlotnik <[email protected]>
yingzhanredhat pushed a commit to yingzhanredhat/release that referenced this pull request Dec 24, 2024
…shift#58241)

OpenShift update while OCL is enabled and rolled out to a node
openshift-machine-config-operator-master-presubmits: Configuring the job

Co-authored-by: Zack Zlotnik <[email protected]>
krishvoor pushed a commit to krishvoor/release that referenced this pull request Jan 29, 2025
…shift#58241)

OpenShift update while OCL is enabled and rolled out to a node
openshift-machine-config-operator-master-presubmits: Configuring the job

Co-authored-by: Zack Zlotnik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants