Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use v4.3.0 git-sync instead of v4.2.3 to fix unreleased lock bug #58154

Merged
merged 1 commit into from
Oct 24, 2024
Merged

use v4.3.0 git-sync instead of v4.2.3 to fix unreleased lock bug #58154

merged 1 commit into from
Oct 24, 2024

Conversation

smg247
Copy link
Member

@smg247 smg247 commented Oct 24, 2024

v4.3.0 needed to pick up bugfix for unreleased lock

/hold Depends on #58153

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
@bear-redhat
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 24, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@smg247: no rehearsable tests are affected by this change

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bear-redhat, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smg247
Copy link
Member Author

smg247 commented Oct 24, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

@smg247: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit da17fbe into openshift:master Oct 24, 2024
19 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the use-v4.3.0-git-sync branch October 24, 2024 19:24
ptalgulk01 pushed a commit to ptalgulk01/release that referenced this pull request Oct 29, 2024
@smg247
use v4.3.0 git-sync instead of v4.2.3 to fix unreleased lock bug (ope…
af9ee97 
…nshift#58154)
obochan-rh pushed a commit to obochan-rh/release that referenced this pull request Oct 31, 2024
@smg247 @obochan-rh
use v4.3.0 git-sync instead of v4.2.3 to fix unreleased lock bug (ope…
1b39f3d 
…nshift#58154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradmwilliams bradmwilliams Awaiting requested review from bradmwilliams

@danilo-gemoli danilo-gemoli Awaiting requested review from danilo-gemoli

Assignees

@bear-redhat bear-redhat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smg247 @bear-redhat @openshift-ci-robot