STOR-2023: Adapt smb csi e2e tests for OCP

[Phaow]

STOR-2023: Adapt smb csi e2e tests for OCP

• After test: add default namespace in examples to fix e2e test failure kubernetes-csi/csi-driver-smb#817 the e2e will install the helm upstream driver version by default in BeforeSuite, it will impact our presubmit job smb-operator-e2e-extended in csi-operator, try to make it compatible in test: use env var for enable driver install in e2e kubernetes-csi/csi-driver-smb#854.
• Introduce the env var PRE_INSTALL_SMB_PROVISIONER to make sure our test target is the installed downstream csi driver.

[openshift-ci-robot]

@Phaow: This pull request references STOR-2023 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

STOR-2023: Adapt smb csi e2e tests for OCP

• After test: add default namespace in examples to fix e2e test failure kubernetes-csi/csi-driver-smb#817 the e2e will install the helm upstream driver version by default in BeforeSuite, it will impact our presubmit job smb-operator-e2e-extended in csi-operator, try to make it compatible in test: use env var for enable driver install in e2e kubernetes-csi/csi-driver-smb#854.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Phaow]

/hold
Wait for openshift/csi-driver-smb#15 merged to rehearse.

[openshift-ci-robot]

@Phaow, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: failed to load registry file /var/tmp/gitrepo3737703218/ci-operator/step-registry/openshift/e2e/azure/csi/smb/extended/openshift-e2e-azure-csi-smb-extended-chain.yaml: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal bool into Go struct field StepParameter.chain.steps.env.default of type string

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci-robot]

@Phaow: This pull request references STOR-2023 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

STOR-2023: Adapt smb csi e2e tests for OCP

• After test: add default namespace in examples to fix e2e test failure kubernetes-csi/csi-driver-smb#817 the e2e will install the helm upstream driver version by default in BeforeSuite, it will impact our presubmit job smb-operator-e2e-extended in csi-operator, try to make it compatible in test: use env var for enable driver install in e2e kubernetes-csi/csi-driver-smb#854.
• Introduce the env var PRE_INSTALL_SMB_PROVISIONER to make sure our test target is the installed downstream csi driver.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@Phaow: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-csi-operator-master-smb-operator-e2e-extended	openshift/csi-operator	presubmit	Registry content changed
pull-ci-openshift-csi-operator-release-4.19-smb-operator-e2e-extended	openshift/csi-operator	presubmit	Registry content changed
pull-ci-openshift-csi-operator-release-4.18-smb-operator-e2e-extended	openshift/csi-operator	presubmit	Registry content changed
pull-ci-openshift-csi-operator-release-4.17-smb-operator-e2e-extended	openshift/csi-operator	presubmit	Registry content changed
pull-ci-openshift-csi-operator-release-4.16-smb-operator-e2e-extended	openshift/csi-operator	presubmit	Registry content changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[Phaow]

/pj-rehearse pull-ci-openshift-csi-operator-master-smb-operator-e2e-extended

[openshift-ci-robot]

@Phaow: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Phaow]

/pj-rehearse ack

[openshift-ci-robot]

@Phaow: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Phaow]

/hold cancel

[Phaow]

Hi @mpatlasov @dfajmon , could you please help take a look when you get a chance? Thank you!

[mpatlasov]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov, Phaow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ci-operator/step-registry/openshift/e2e/azure/csi/OWNERS [mpatlasov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@Phaow: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.