Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cvo: explicitly import hypershift base images #57408

Merged
merged 1 commit into from
Oct 3, 2024
Merged

cvo: explicitly import hypershift base images #57408

merged 1 commit into from
Oct 3, 2024

Conversation

petr-muller
Copy link
Member

Follow #57123

@petr-muller
Copy link
Member Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

This was referenced Oct 2, 2024
Merged
Merged
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2024
@openshift-ci openshift-ci bot requested review from hongkailiu and wking October 2, 2024 18:18
@petr-muller
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cluster-version-operator-release-4.16-e2e-hypershift pull-ci-openshift-cluster-version-operator-release-4.16-e2e-hypershift-conformance pull-ci-openshift-cluster-version-operator-master-e2e-hypershift pull-ci-openshift-cluster-version-operator-master-e2e-hypershift-conformance

@openshift-ci-robot
Copy link
Contributor

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@petr-muller: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-operator openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-ovn openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-ovn-upgrade-into-change openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-ovn-upgrade-out-of-change openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-master-e2e-aws-ovn-techpreview openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-master-e2e-hypershift openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-master-e2e-hypershift-conformance openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-master-gofmt openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-master-images openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-master-lint openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-master-okd-scos-images openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-master-unit openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.15-e2e-agnostic-operator openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.15-e2e-agnostic-ovn openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.15-e2e-agnostic-ovn-upgrade-into-change openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.15-e2e-agnostic-ovn-upgrade-out-of-change openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.15-e2e-hypershift openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.15-e2e-hypershift-conformance openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.15-gofmt openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.15-images openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.15-lint openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.15-unit openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.18-e2e-agnostic-operator openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.18-e2e-agnostic-ovn openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.18-e2e-agnostic-ovn-upgrade-into-change openshift/cluster-version-operator presubmit Ci-operator config changed

A total of 67 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@hongkailiu
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Oct 2, 2024

Rehearsals passed, except for the dev branch one, but even that one didn't fail on image-import.

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@wking: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 2, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

@petr-muller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-version-operator/master/e2e-hypershift 85ad8c4 link unknown /pj-rehearse pull-ci-openshift-cluster-version-operator-master-e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c5bdad9 into openshift:master Oct 3, 2024
16 of 17 checks passed
@petr-muller petr-muller deleted the cvo-fix-hypershift branch October 4, 2024 11:24
@hongkailiu hongkailiu mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

@wking wking Awaiting requested review from wking

Assignees

@hongkailiu hongkailiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petr-muller @openshift-ci-robot @hongkailiu @wking