Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0 presubmit job for devfile registry operator #44995

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Oct 27, 2023

In devfile/registry-operator#56, we are adding integration testing for release publishing using the release tag push trigger to ensure the release being published is working as intended.

In devfile/registry-operator#57, we are adding integration testing for release branch PRs before creating the releases off of the target release branch.

In this PR, we would like to include the same prow job (for v0 releases) to run integration testing in OpenShift.

fixes devfile/api#1267

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@michael-valdron
Copy link
Member Author

/test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 27, 2023
@michael-valdron michael-valdron force-pushed the feat/devfile-registry-operator-release-ci branch from 882b052 to d34efa7 Compare October 27, 2023 21:17
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@michael-valdron
Copy link
Member Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@michael-valdron: no rehearsable tests are affected by this change

@michael-valdron
Copy link
Member Author

/test all

@michael-valdron
Copy link
Member Author

fixes devfile/api#1267

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2023
@michael-valdron michael-valdron force-pushed the feat/devfile-registry-operator-release-ci branch from d34efa7 to b4a75d9 Compare October 31, 2023 21:22
@openshift-ci-robot
Copy link
Contributor

@michael-valdron, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto master: %!w(<nil>)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@michael-valdron michael-valdron force-pushed the feat/devfile-registry-operator-release-ci branch from b4a75d9 to 930ab58 Compare October 31, 2023 21:29
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2023
@michael-valdron
Copy link
Member Author

/test all

@michael-valdron michael-valdron force-pushed the feat/devfile-registry-operator-release-ci branch from 930ab58 to 0d2ff65 Compare November 1, 2023 16:52
@openshift-ci-robot
Copy link
Contributor

@michael-valdron, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: invalid postsubmit job branch-ci-devfile-registry-operator-^[0-9]+\.[0-9]+\.[0-9]+(\-rc\.[0-9]+)?$-v4.12-registry-operator-integration-test: name: must match regex "^[A-Za-z0-9-._]+$"
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
@michael-valdron
Copy link
Member Author

/test all

@michael-valdron michael-valdron force-pushed the feat/devfile-registry-operator-release-ci branch from 0d2ff65 to a437e6e Compare November 1, 2023 17:10
@michael-valdron
Copy link
Member Author

/test all

@michael-valdron michael-valdron force-pushed the feat/devfile-registry-operator-release-ci branch from a437e6e to 771e311 Compare November 3, 2023 23:47
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 3, 2023
@michael-valdron michael-valdron changed the title Release postsubmit job for devfile registry operator Release v0 presubmit job for devfile registry operator Nov 3, 2023
@michael-valdron
Copy link
Member Author

/pj-rehearse

1 similar comment
@michael-valdron
Copy link
Member Author

/pj-rehearse

@michael-valdron michael-valdron force-pushed the feat/devfile-registry-operator-release-ci branch from 771e311 to 144c953 Compare November 6, 2023 18:45
@michael-valdron michael-valdron marked this pull request as ready for review November 6, 2023 18:48
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2023
@openshift-ci openshift-ci bot requested review from feloy and thepetk November 6, 2023 18:49
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron michael-valdron force-pushed the feat/devfile-registry-operator-release-ci branch from 144c953 to d5d5c43 Compare November 6, 2023 18:54
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@michael-valdron: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-devfile-registry-operator-release-v0-v4.12-images devfile/registry-operator presubmit Presubmit changed
pull-ci-devfile-registry-operator-release-v0-v4.12-registry-operator-integration-test devfile/registry-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@michael-valdron
Copy link
Member Author

/pj-rehearse

Copy link
Member

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2023
Copy link
Contributor

openshift-ci bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 6, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit ef23f9c into openshift:master Nov 6, 2023
Copy link
Contributor

openshift-ci bot commented Nov 6, 2023

@michael-valdron: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically publish registry operator release images
4 participants