-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openstack/nfv: find PCI address using sriovnetworknodestates #43986
Conversation
Instead of hardcoding the PCI address, let's just get the real one attached to the desired network; so we improve compatibility with how machines are configured (q35, etc).
The job would randomly fail because we need openshift/sriov-network-operator#837 but let's see how it works (and also to test the newly deployed NFV cloud on OSP 17.1): /pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-nfv-intel |
/pj-rehearse abort |
/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-nfv-intel |
ci-operator/step-registry/openstack/test/dpdk/openstack-test-dpdk-commands.sh
Show resolved
Hide resolved
/pj-rehearse abort |
/hold needs testing |
/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-nfv-intel |
/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-nfv-hwoffload |
/hold cancel @mandre @MaysaMacedo if you see Thanks |
The openstack-test-sriov step failed with
Looks like we need to tell it where to find the |
/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-nfv-hwoffload |
[REHEARSALNOTIFIER]
A total of 57 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/pj-rehearse ack
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/pj-rehearse ack |
@EmilienM: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Instead of hardcoding the PCI address, let's just get the real one
attached to the desired network; so we improve compatibility with
how machines are configured (q35, etc).