Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openstack/nfv: find PCI address using sriovnetworknodestates #43986

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

EmilienM
Copy link
Member

@EmilienM EmilienM commented Oct 4, 2023

Instead of hardcoding the PCI address, let's just get the real one
attached to the desired network; so we improve compatibility with
how machines are configured (q35, etc).

Instead of hardcoding the PCI address, let's just get the real one
attached to the desired network; so we improve compatibility with
how machines are configured (q35, etc).
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2023
@EmilienM
Copy link
Member Author

EmilienM commented Oct 4, 2023

The job would randomly fail because we need openshift/sriov-network-operator#837 but let's see how it works (and also to test the newly deployed NFV cloud on OSP 17.1):

/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-nfv-intel

@EmilienM
Copy link
Member Author

EmilienM commented Oct 4, 2023

/pj-rehearse abort

@EmilienM
Copy link
Member Author

EmilienM commented Oct 4, 2023

/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-nfv-intel

@EmilienM
Copy link
Member Author

EmilienM commented Oct 4, 2023

/pj-rehearse abort

@EmilienM
Copy link
Member Author

EmilienM commented Oct 4, 2023

/hold needs testing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2023
@EmilienM
Copy link
Member Author

EmilienM commented Oct 4, 2023

/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-nfv-intel

@EmilienM
Copy link
Member Author

EmilienM commented Oct 5, 2023

/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-nfv-hwoffload

@EmilienM
Copy link
Member Author

EmilienM commented Oct 5, 2023

openstack-nfv-intel is broken until we fix the hardware and merge openshift/sriov-network-operator#837 so for this PR we'll rely on openstack-nfv-hwoffload.

/hold cancel

@mandre @MaysaMacedo if you see openstack-nfv-hwoffload rehearse passing, we can pj-rehearse ack and lgtm (if the change looks good to you); so we'll be able to test openshift/sriov-network-operator#837 as soon as the HW is fixed (see VEXXHOST ticket).

Thanks

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2023
@mandre
Copy link
Member

mandre commented Oct 5, 2023

The openstack-test-sriov step failed with

Cloud openstack was not found.

Looks like we need to tell it where to find the clouds.yaml file. I'll update the patch.

@mandre
Copy link
Member

mandre commented Oct 5, 2023

/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-nfv-hwoffload

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@EmilienM: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-api-provider-openstack-release-4.10-e2e-openstack-nfv-mellanox openshift/cluster-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-openstack-release-4.9-e2e-openstack-nfv-mellanox openshift/cluster-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-installer-release-4.13-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.12-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.11-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.10-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-master-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.16-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.15-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.14-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.13-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.13-e2e-openstack-nfv-hwoffload openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.12-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.12-e2e-openstack-nfv-hwoffload openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.11-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.11-e2e-openstack-nfv-hwoffload openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.10-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.9-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-master-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-master-e2e-openstack-nfv-hwoffload openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.16-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.16-e2e-openstack-nfv-hwoffload openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.15-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.15-e2e-openstack-nfv-hwoffload openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.14-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.14-e2e-openstack-nfv-hwoffload openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.13-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.12-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.11-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.11-e2e-openstack-nfv-mellanox openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-master-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.16-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.15-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.14-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-nfv-intel-kuryr N/A periodic Registry content changed

A total of 57 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/pj-rehearse ack

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandre
Copy link
Member

mandre commented Oct 5, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2023

@EmilienM: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-nfv-intel 40b49c4 link unknown /pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-nfv-intel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 0a8d603 into openshift:master Oct 5, 2023
@pierreprinetti pierreprinetti deleted the nfv_pci branch October 5, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants