NE-1324: Make caller-reference unique for AWS PHZ creation #43517
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@gcs278: This pull request references NE-1324 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/pj-rehearse pull-ci-openshift-external-dns-operator-main-e2e-aws-shared-vpc-phz-operator |
|
@gcs278: This pull request references NE-1324 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@patrickdillon Could you take a quick look at this and give |
|
@gcs278: This pull request references NE-1324 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
gcs278
force-pushed
the
shared-vpc-e2e-caller-reference-fix
branch
from
85626f0 to
15868d4
Compare
|
@gcs278: This pull request references NE-1324 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
gcs278
force-pushed
the
shared-vpc-e2e-caller-reference-fix
branch
2 times, most recently
from
45a9ed7 to
e31fbc4
Compare
|
/pj-rehearse pull-ci-openshift-external-dns-operator-main-e2e-aws-shared-vpc-phz-operator Just trying random jobs |
|
/lgtm |
|
/pj-rehearse periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-ovn-shared-vpc-phz-techpreview |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-byo-route53-f14 |
|
/hold
I've must of missed something. |
openshift-ci
bot
added
the
do-not-merge/hold
gcs278
force-pushed
the
shared-vpc-e2e-caller-reference-fix
branch
from
e31fbc4 to
403955e
Compare
|
/pj-rehearse pull-ci-openshift-external-dns-operator-main-e2e-aws-shared-vpc-phz-operator |
|
This failed too. I'm not sure why I don't have this files, but other steps do. |
|
/assign @alebedev87 |
gcs278
force-pushed
the
shared-vpc-e2e-caller-reference-fix
branch
from
403955e to
c04511e
Compare
|
@gcs278: This pull request references NE-1324 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The caller-reference when creating a private hosted zone needs to be unique. In some pre-submit job run situations, it reuses the cluster name, causing caller-reference to reused. This solution simply adds a timestamp to caller reference to always ensure it's unique.
gcs278
force-pushed
the
shared-vpc-e2e-caller-reference-fix
branch
from
c04511e to
42ad710
Compare
|
[REHEARSALNOTIFIER]
A total of 78 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-external-dns-operator-main-e2e-aws-shared-vpc-phz-operator |
|
/pj-rehearse periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-ovn-shared-vpc-phz-techpreview |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/approve |
openshift-ci
bot
added
the
approved
|
@gcs278: This pull request references NE-1324 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/pj-rehearse ack |
openshift-ci-robot
added
the
rehearsals-ack
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87, gcs278, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@gcs278: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The caller-reference when creating a private hosted zone needs to be unique. In some pre-submit job run situations for external-dns-operator ( e.g. openshift/external-dns-operator#198), it reuses the cluster name, causing caller-reference to reused. This solution simply adds a timestamp to caller reference to always ensure it's unique.
As an example job 1 (failed) and job 2 (failed) had the same name which produced the error on the job 2 run such as:
It appears to reuse the cluster name upon some types of failures, but I have had a successful run since this naming collision with caller-reference.
PR that introduced
e2e-aws-shared-vpc-phz-operator: #42894