Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPVE-588: chore: add multi-node test configuration for LVMS #42554

Merged
merged 3 commits into from
Aug 23, 2023
Merged

OCPVE-588: chore: add multi-node test configuration for LVMS #42554

merged 3 commits into from
Aug 23, 2023

Conversation

jakobmoellerdev
Copy link
Contributor

Adds multi-node tests in addition to the existing SNO-tests

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 22, 2023 •
edited by openshift-ci bot
Loading

@jakobmoellerdev: This pull request references OCPVE-588 which is a valid jira issue.

In response to this:

Adds multi-node tests in addition to the existing SNO-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 22, 2023
@jakobmoellerdev
Copy link
Contributor Author

/pj-rehearse

@openshift-ci openshift-ci bot requested review from jeff-roche and jerpeter1 August 22, 2023 12:36
@jakobmoellerdev
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-lvm-operator-main-lvm-operator-e2e-aws

@jakobmoellerdev
Copy link
Contributor Author

/pj-rehearse

@jakobmoellerdev jakobmoellerdev mentioned this pull request Aug 23, 2023
Merged
@jakobmoellerdev
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-lvm-operator-main-lvm-operator-e2e-aws-sno

@jakobmoellerdev
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 23, 2023
@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 23, 2023
@jakobmoellerdev
Copy link
Contributor Author

/test config

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 23, 2023
@jakobmoellerdev
Copy link
Contributor Author

/test config

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jakobmoellerdev: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-lvm-operator-main-lvm-operator-e2e-aws-sno openshift/lvm-operator presubmit Presubmit changed
pull-ci-openshift-lvm-operator-main-lvm-operator-e2e-aws openshift/lvm-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jakobmoellerdev
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 23, 2023
@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0b90071 into openshift:master Aug 23, 2023
prb112 pushed a commit to prb112/openshift-release that referenced this pull request Sep 12, 2023
@jakobmoellerdev @prb112
OCPVE-588: chore: add multi-node test configuration for LVMS (openshi…
881e1f9 
…ft#42554)

* chore: add multi-node test configuration for LVMS

* chore: add make prefix for disk install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-roche jeff-roche Awaiting requested review from jeff-roche

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

Assignees

@suleymanakbas91 suleymanakbas91

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakobmoellerdev @openshift-ci-robot @suleymanakbas91 @openshift-merge-robot