Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ginkgo filter #34500

Merged
merged 1 commit into from
Dec 5, 2022
Merged

fix ginkgo filter #34500

merged 1 commit into from
Dec 5, 2022

Conversation

Xia-Zhao-rh
Copy link
Contributor

Hi,
@kuiwang02 Please help to review it, thanks

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2022
@openshift-ci-robot
Copy link
Contributor

@Xia-Zhao-rh: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-aws-c2s-ipi-disconnected-private-p3-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-aws-ipi-disconnected-private-p3-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-aws-ipi-private-p2-f7 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-aws-ipi-private-p3-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-aws-c2s-ipi-disconnected-private-p3-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-c2s-ipi-disconnected-private-p3-f28-destructive N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

kuiwang02
kuiwang02 reviewed Dec 2, 2022
View reviewed changes
...t/openshift-tests-private/openshift-openshift-tests-private-release-4.11__amd64-nightly.yaml Outdated
@@ -546,6 +546,7 @@ tests:
E2E_RUN_TAGS: '@aws-ipi and @disconnected and @network-openshiftsdn and not
@fips'
TAG_VERSION: '@4.11'
TEST_FILTERS: ~ChkUpgrade&;~NonPreRelease&;~Serial;~Disruptive;~ConnectedOnly&;~HyperShiftMGMT&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xia-Zhao-rh private cluster is not disconnect, no need ~ConnectedOnly&

kuiwang02
kuiwang02 reviewed Dec 5, 2022
View reviewed changes
...t/openshift-tests-private/openshift-openshift-tests-private-release-4.11__amd64-nightly.yaml Outdated
@@ -546,6 +546,7 @@ tests:
E2E_RUN_TAGS: '@aws-ipi and @disconnected and @network-openshiftsdn and not
@fips'
TAG_VERSION: '@4.11'
TEST_FILTERS: ~ChkUpgrade&;~NonPreRelease&;~Serial;~Disruptive;~DisconnectedOnly&;~HyperShiftMGMT&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xia-Zhao-rh no need it and just take default value.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2022

@Xia-Zhao-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kuiwang02
Copy link
Contributor

/pj-rehearse skip

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 5, 2022
@kuiwang02
Copy link
Contributor

/approve

@kuiwang02
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kuiwang02, Xia-Zhao-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5dc0eb6 into openshift:master Dec 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2022

@Xia-Zhao-rh: Updated the following 3 configmaps:

  • ci-operator-4.11-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-openshift-tests-private-release-4.11__amd64-nightly.yaml using file ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.11__amd64-nightly.yaml
  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-openshift-tests-private-release-4.12__amd64-stable.yaml using file ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.12__amd64-stable.yaml
  • ci-operator-4.13-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-openshift-tests-private-release-4.13__amd64-nightly.yaml using file ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.13__amd64-nightly.yaml

In response to this:

Hi,
@kuiwang02 Please help to review it, thanks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuiwang02 kuiwang02 kuiwang02 left review comments

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

@rioliu-rh rioliu-rh Awaiting requested review from rioliu-rh

Assignees

@kuiwang02 kuiwang02

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xia-Zhao-rh @openshift-ci-robot @kuiwang02 @openshift-merge-robot