Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to new script name, which doesn't need CI_CHE_OPERATOR_IMAGE passed into it anymore (https://github.com/eclipse/che/issues/21836) #34307

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

nickboldt
Copy link
Contributor

@nickboldt nickboldt commented Nov 24, 2022

update to new script name, which doesn't need CI_CHE_OPERATOR_IMAGE passed into it anymore
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2022

Hi @nickboldt. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@nickboldt: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-eclipse-che-che-operator-main-v11-devworkspace-happy-path eclipse-che/che-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@nickboldt nickboldt changed the title chore: update to new script name, which doesn't need CI_CHE_OPERATOR_IMAGE passed into it anymore chore: update to new script name, which doesn't need CI_CHE_OPERATOR_IMAGE passed into it anymore (https://github.com/eclipse/che/issues/21836) Nov 24, 2022
@flacatus
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 24, 2022
@tolusha
Copy link
Contributor

tolusha commented Nov 24, 2022

Sounds good

@flacatus
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 24, 2022
@nickboldt
Copy link
Contributor Author

So how do we make this mergeable?

image

@tolusha
Copy link
Contributor

tolusha commented Dec 7, 2022

/rehearsals-ack

@tolusha
Copy link
Contributor

tolusha commented Dec 7, 2022

/lgtm

@tolusha
Copy link
Contributor

tolusha commented Dec 7, 2022

/ok-to-test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flacatus, nickboldt, tolusha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2022

@nickboldt: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha tolusha removed their assignment Dec 7, 2022
@flacatus
Copy link
Contributor

flacatus commented Dec 7, 2022

/rehearsals-ack

@rhopp
Copy link
Contributor

rhopp commented Dec 7, 2022

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit 47c07e7 into openshift:master Dec 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2022

@nickboldt: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key eclipse-che-che-operator-main__v11.yaml using file ci-operator/config/eclipse-che/che-operator/eclipse-che-che-operator-main__v11.yaml

In response to this:

chore: update to new script name, which doesn't need CI_CHE_OPERATOR_IMAGE passed into it anymore

New script: https://github.com/eclipse-che/che-operator/commits/main/build/scripts/olm/test-catalog-from-sources.sh
Old script: https://github.com/eclipse-che/che-operator/blob/7.56.x/build/scripts/olm/testCatalogFromSources.sh

re: eclipse-che/che#21836

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants