Add issuer in the vault's kubernetes config #19808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
|
/hold We need to understand the security implications of this |
openshift-ci
bot
added
the
do-not-merge/hold
|
after a discussion with auth team in https://coreos.slack.com/archives/CB48XQ4KZ/p1624965518168300 we figure out that we need to add the issuer value in the config. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
droslean
changed the title
Signed-off-by: Nikolaos Moraitis <[email protected]>
alvaroaleman
approved these changes
Jun 29, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, droslean The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @openshift/openshift-team-developer-productivity-platform-maintainers @alvaroaleman
The
secret-bootstrapjob and thevault-secret-collection-managerwere failing with errorErrors:* claim "iss" is invalidThat started to happen after we upgrade the app.ci cluster. After some investigation and advice by vault issue hashicorp/vault-k8s#14 which led me to external-secrets/kubernetes-external-secrets#721 it seems that disabling the
issvalidation in Kubernetes config solved the issue.@alvaroaleman I am not sure if this is the best way to fix this or we need to add a specific issuer in the config and keep the validation. Can you check?
Signed-off-by: Nikolaos Moraitis [email protected]