WIP: Split into subpackages #12
Conversation
- Some of our hacks (e.g. the systemd coredump bit) are maipo-specific - We really want to clearly distinguish these things; separate `-release` packages helps, but even better is having different version numbers in `/etc/os-release`.
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/L
|
This encodes the |
|
Will having two spec files cause a problem for |
| %setup -q -n redhat-release-%{base_release_version} | ||
|
|
||
| %build | ||
| make fs-maipo |
There was a problem hiding this comment.
Heck, we could collapse this into a single spec and just use the %rhel macro from our buildroot, right?
Yep, it'll break it today. I thought of that but had been putting off the problem 😄 - But you're right to call this out now. Maybe the simplest is to use git branches for this, we could split off a |
or
I don't have enough experience with spec files to know if it would be easier to maintain two of them (porting changes between the two) or have a massive one with a bunch of conditionals. I'd be fine with git branches for now, but defer to others with more expertise. |
|
Obsoleted by #13 |
maipo-specific
-releasepackages helps, but even better is having differentversion numbers in
/etc/os-release.