Bug 1908762: Cherry-pick commits for multicast support for v4 and v6 #403
Conversation
Signed-off-by: Dumitru Ceara <[email protected]> (cherry picked from commit c21cce7)
in an effort to break up the large the ovn package move address_set this will make mocking the address_set interface for testing much easier Signed-off-by: Jacob Tanenbaum <[email protected]> (cherry picked from commit d6f2261)
Commit 40a90f0 removed the multicast deny port group and used instead the cluster port group. However, this breaks pod-to-pod multicast when pods reside on different nodes. That is because OVN ACLs are applied on all logical switch ports, including logical switch ports connected to router ports. Hence, an ACL of the form "if ip.mcast then deny" applied on the clusterPortGroup will drop all multicast traffic that would normally be routed by the cluster router even when multicast is allowed for a namespace. Instead, add a new (smaller) cluster wide group that only contains the node logical switch ports connected to the cluster router. This allows us to define two allow ACLs for multicast traffic from/to node switches to/from cluster router, therefore not breaking the namespace multicast allow policy if pods reside on different nodes. Fixes: 40a90f0 ("Migrate default deny multicast policy to port-group") Signed-off-by: Dumitru Ceara <[email protected]> (cherry picked from commit 3864f2b)
Enable MLD Snoop and MLD relay to allow multicast connectivity across nodes. Extend the IPv4 multicast network policies to make them applicable to IPv6. Signed-off-by: Dumitru Ceara <[email protected]> (cherry picked from commit cbc7294)
Create a multicast source in one node and 2 listener in another node. One of the listener should join the group and receive the multicast traffic, and the other listener should try to join another group that does not exist and fail to receive any multicast traffic. Organize the e2e folder correctly to avoid issues with go modules and imports. Disable IPv6 multicast tests for now because iperf in agnhost images doesn't support binding a server to an IPv6 multicast group: bash-4.3# iperf -s -B ff00:0:3:3::3 -u -t 30 -i 5 -V error: Try again Co-authored-by: Dumitru Ceara <[email protected]> Signed-off-by: Antonio Ojea <[email protected]> Signed-off-by: Dumitru Ceara <[email protected]> (cherry picked from commit e6f2d17)
openshift-ci-robot
added
the
bugzilla/severity-high
|
@abhat: This pull request references Bugzilla bug 1908762, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
|
/test e2e-aws-ovn |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhat, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@abhat: All pull requests linked via external trackers have merged: Bugzilla bug 1908762 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cherry-pick commits for multicast support for v4 and v6
Signed-off-by: Aniket Bhat [email protected]