-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transparant and explicit proxy terraform scripts #269
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
+ Coverage 25.27% 25.91% +0.63%
==========================================
Files 24 25 +1
Lines 1812 1837 +25
==========================================
+ Hits 458 476 +18
- Misses 1329 1333 +4
- Partials 25 28 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I ran a test locally by launching both types of proxy and confirming the proxy was up and running via the web UI. I did not do any further testing after that.
Only other comment I have is we could probably share a lot of this Terraform code in a common module since they are similar stacks, but as far as an example goes this seems fine to me!
/lgtm
Co-authored-by: Josh Branham <[email protected]>
/lgtm |
@abyrne55: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abyrne55 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@abyrne55: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
What does this PR do?
This PR supersedes #267 and implements OSD-23854, which calls for the code from abyrne55/transparent-proxy-setup to be moved into this repo's "example" code directory. The two directories created by this PR (vpc-proxied-explicit and vpc-proxied-transparent) contain Terraform scripts for quickly deploying AWS VPCs that explicitly- or transparently-proxy their traffic through a generated proxy server.
Checklist
[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have tested the functionality against gcp / aws, it doesn't cause any regressionHow to test this PR locally
Please read through and run through the two READMEs included in this PR