Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transparant and explicit proxy terraform scripts #269

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

abyrne55
Copy link
Contributor

What does this PR do?

This PR supersedes #267 and implements OSD-23854, which calls for the code from abyrne55/transparent-proxy-setup to be moved into this repo's "example" code directory. The two directories created by this PR (vpc-proxied-explicit and vpc-proxied-transparent) contain Terraform scripts for quickly deploying AWS VPCs that explicitly- or transparently-proxy their traffic through a generated proxy server.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have tested the functionality against gcp / aws, it doesn't cause any regression
  • I have added execution results to the PR's readme

How to test this PR locally

Please read through and run through the two READMEs included in this PR

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.91%. Comparing base (060ba01) to head (617bbf4).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
+ Coverage   25.27%   25.91%   +0.63%     
==========================================
  Files          24       25       +1     
  Lines        1812     1837      +25     
==========================================
+ Hits          458      476      +18     
- Misses       1329     1333       +4     
- Partials       25       28       +3     

see 14 files with indirect coverage changes

Copy link
Contributor

@joshbranham joshbranham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I ran a test locally by launching both types of proxy and confirming the proxy was up and running via the web UI. I did not do any further testing after that.

Only other comment I have is we could probably share a lot of this Terraform code in a common module since they are similar stacks, but as far as an example goes this seems fine to me!

/lgtm

examples/aws/terraform/vpc-proxied-explicit/variables.tf Outdated Show resolved Hide resolved
examples/aws/terraform/vpc-proxied-transparent/main.tf Outdated Show resolved Hide resolved
examples/aws/terraform/vpc-proxied-explicit/main.tf Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2024
@abyrne55
Copy link
Contributor Author

abyrne55 commented Oct 4, 2024

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

@abyrne55: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abyrne55

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2024
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

@abyrne55: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@joshbranham
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a62e053 into openshift:main Oct 4, 2024
6 checks passed
@abyrne55 abyrne55 deleted the OSD-23854 branch October 4, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants