Fetch url list from github first before falling back to local

[AlexVulaj]

OSD-22628

• Enhancement/Feature

What does this PR do? / Related Issues / Jira

Fetch the URL list from github first. Fall back to the local list (current behavior) if that fails, i.e. github is down.

Checklist

• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have tested the functionality against gcp / aws, it doesn't cause any regression
• I have added execution results to the PR's readme

How to test this PR locally / Special Instructions

Pull this commit down and run it exactly as you normally would. You should see a Using egress URL list from... line in the console output if the new list is being used.

The file blob can be viewed with https://api.github.com/repos/openshift/osd-network-verifier/git/blobs/<file_sha>

Logs

./osd-network-verifier egress --subnet-id subnet-0ca196afecc8548bb --security-group-ids sg-041c0bed52e968857
Using region: us-east-1
Using egress URL list from https://api.github.com/repos/openshift/osd-network-verifier/contents/pkg/data/egress_lists/aws-classic.yaml?ref=main at SHA 5fd26419a0a6529a2a692fee0abe591d58542ec3
Created instance with ID: i-02754cba15b7909b2
Deleting instance with ID: i-02754cba15b7909b2
Summary:
All tests passed!
Success

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 22.74%. Comparing base (ee0b6e0) to head (14f1363).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   32.67%   22.74%   -9.93%     
==========================================
  Files          13       23      +10     
  Lines        1160     1666     +506     
==========================================
  Hits          379      379              
- Misses        763     1269     +506     
  Partials       18       18              

Files	Coverage Δ
cmd/egress/cmd.go	0.00% <0.00%> (ø)
pkg/verifier/aws/entry_point.go	0.00% <0.00%> (ø)
pkg/data/egress_lists/egress_lists.go	0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

[luis-falcon]

/lgtm

[rafael-azevedo]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rafael-azevedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rafael-azevedo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@AlexVulaj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dakotalongRH]

/lgtm