Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy URL lists from golden-ami repo #238

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

eth1030
Copy link
Contributor

@eth1030 eth1030 commented Jun 7, 2024

  • Enhancement/Feature

What does this PR do? / Related Issues / Jira

add egress URL lists to verifier repo

OSD-22627

@openshift-ci openshift-ci bot requested review from AlexVulaj and reedcort June 7, 2024 18:53
Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

@eth1030: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.32%. Comparing base (ca5a4d7) to head (4b7c161).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   26.32%   26.32%           
=======================================
  Files          11       11           
  Lines        1056     1056           
=======================================
  Hits          278      278           
  Misses        764      764           
  Partials       14       14           

@fahlmant
Copy link
Contributor

fahlmant commented Jun 7, 2024

What's the config.yaml file for? Does it cover something else besides AWS, HCP or GCP?

@eth1030
Copy link
Contributor Author

eth1030 commented Jun 7, 2024

@fahlmant Don't know what config.yaml is for, but it existed in the golden-ami repo. Wanted to keep it consistent.

@AlexVulaj
Copy link
Contributor

/lgtm

1 similar comment
@luis-falcon
Copy link
Contributor

/lgtm

@fahlmant
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
@rafael-azevedo
Copy link
Contributor

/lgtm

@fahlmant
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2024
Copy link
Contributor

@fahlmant fahlmant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fahlmant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 46fefcb into openshift:main Jun 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants