Ensuring the SG cleanup in case of error when creating the instance

[bdematte]

What does this PR do? / Related Issues / Jira

Bug fix for OSD-16076
In case we got an error and we couldn't create the EC2 instance, we should still clean the SG up in case we created one so skipping the log analysis and the TerminateInstace but continuing the function to cleanup the SG.
This is only a first part of the fix (even though it should be the most common case we are facing) - we still need to better handle the error case inside the 'CreateSecurityGroup' function itself.

Checklist

• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have tested the functionality against gcp / aws, it doesn't cause any regression
• I have added execution results to the PR's readme

Reviewer's Checklist

• (This needs to be done after technical review) I've run the branch on my local, verified that the functionality is ok

How to test this PR locally / Special Instructions

Logs

[codecov-commenter]

Codecov Report

Merging #179 (946f507) into main (b33fd4c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   10.11%   10.10%   -0.01%     
==========================================
  Files          17       17              
  Lines        1137     1138       +1     
==========================================
  Hits          115      115              
- Misses       1012     1013       +1     
  Partials       10       10              

Impacted Files	Coverage Δ
pkg/verifier/aws/entry_point.go	0.00% <0.00%> (ø)

[openshift-ci]

@bdematte: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[abyrne55]

/label tide/merge-method-squash
/lgtm

Tested locally by creating an IAM user with a policy that allows everything the verifier needs, except for RunInstances. This triggered the newly-added error handler, which I've confirmed deletes the verifier's security group.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abyrne55, bdematte

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bdematte]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment