This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in the database event hook
Alert._set_firing_details()
that causes Alert database record creation to fail if a PagerDuty alert's firing_details field does not contain namespace info. The specific error is as follows:This is due to an
AttributeError
raised when the code tries to fetch a non-existent regex result. With this PR, that exception will now be caught and logged as a warning. This PR also adds a sample alert that triggers this error tosample_incident_alerts.json
and updates the unit tests for the Alert model such that they can now handle these multi-alert sample files.This PR addresses bug OSD-10952.