jenkins: use oc for image tagging
#343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a utility function to login to an OpenShift service and switches to a desired project. I snuck in a small change to the `registry_login()` function to echo out what the command looks like.
This change forgoes the use of `skopeo copy` to tag the container image with an ostree commit and instead directly talks to OpenShift to apply the tag. I think this should be less likely to fail as we don't have to rely on a longer, more network intensive `skopeo copy` operation. Note: we are explicitly tagging the sha256sum reference of the image, rather than re-tagging the `buildmaster` tag. This means the ostree commit tag will always point to the sha256sum of the image, rather than the `buildmaster` tag, which changes each build.
This implements the use of `oc` to handle the tagging of the container image to `alpha` and to garbage collect ostree commit tags that we no longer need.
openshift-ci-robot
added
the
size/M
|
/lgtm |
This was referenced Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do tag manipulation on our
oscontainerimages, we need to useocto operate on the ImageStream, rather than trying to usepodmanandskopeo.The reasoning is that
podmanandskopeocan only operate according to the registry API which lacks a mechanism to "untag" an image. (See containers/skopeo#531 (comment))