scripts/ami-copy-regions: Try waiting on all AMIs #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
|
(Tested lightly locally) |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
cgwalters
force-pushed
the
ami-region-follow
branch
from
19c04c7 to
c688961
Compare
|
/hold cancel Now tested better |
openshift-ci-robot
removed
the
do-not-merge/hold
yuqi-zhang
reviewed
Oct 2, 2018
scripts/ami-copy-regions
Outdated
| # this could take a long time, but in practice EC2 parallelizes | ||
| # so this way we avoid failing if the first image or two happens | ||
| # to take too long. | ||
| for _ in range(1): |
There was a problem hiding this comment.
Maybe this is a really dumb question but what's the point of this line?
There was a problem hiding this comment.
The comment above was attempting to explain that.
There was a problem hiding this comment.
Oh except I meant range(2) here...fixed.
There was a problem hiding this comment.
This by the way is why we have code review 😄
There was a problem hiding this comment.
Yeah, I was slightly confused and thought you were trying to do something magical with a single loop that I wasn't aware of 😄
The copying seems to have added ~14 minutes to the job run, which I guess is normal given that one upload in the cloud job takes about the same time.
- Unbuffer stdout so stderr isn't confusingly first - Use a tuple instead of dict so that we can add the AMIs to a set - Try a --dry-run first so that we verify we have permissions (this may be the issue?) - Finally and perhaps most importantly, wait for every AMI at least once. This way if the first one is slow, we'll move on to the next.
cgwalters
force-pushed
the
ami-region-follow
branch
from
c688961 to
e688e5c
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this may be the issue?)
least once. This way if the first one is slow, we'll move
on to the next.