.gitignore: Empty out #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found it very confusing when I added a `scripts/build-prepare` and it wasn't showing up in `git status`. Turned out to be the `build*` rule in `.gitignore`. A quick glance at `git log` shows those rules were intended to ignore rpmdistro-gitoverlay artifacts. But we don't really encourage doing that in this directory at all, and the metadata now lives in `rdgo` anyways. Also hopefully soon the assembler will learn how to rdgo or equivalent.
openshift-ci-robot
added
the
size/XS
yuqi-zhang
approved these changes
Oct 1, 2018
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it very confusing when I added a
scripts/build-prepareand it wasn't showing up in
git status. Turned out to be thebuild*rule in.gitignore.A quick glance at
git logshows those rules were intended toignore rpmdistro-gitoverlay artifacts. But we don't really
encourage doing that in this directory at all, and the metadata
now lives in
rdgoanyways.Also hopefully soon the assembler will learn how to rdgo or
equivalent.