Fix podman login in various ways #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `set +x` again so we stop echoing to the log - Drop the pull-mount-oscontainer copy of this code - Change the API to accept CREDS directly and parse it inside the API to avoid duplicating that - Also change the API to accept a container name, and parse the registry bit out of that so we only need to juggle a container image name
openshift-ci-robot
added
the
size/S
ashcrow
approved these changes
Oct 1, 2018
yuqi-zhang
approved these changes
Oct 1, 2018
|
/lgtm |
miabbott
added a commit
to miabbott/os
that referenced
this pull request
Oct 1, 2018
In openshift#334, we changed to do the registry login outside of the `pull-mount-oscontainer` script, so that we only require two arguments to the script now. So change the invocation accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set +xagain so we stop echoing to the logthe API to avoid duplicating that
the registry bit out of that so we only need to juggle a
container image name