Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: don't nuke root dir in prep_container_storage() #333

Merged

Conversation

miabbott
Copy link
Member

@miabbott miabbott commented Oct 1, 2018

The function should just nuke the containers dir, rather than the
root of the containers dir.

The function should just nuke the `containers` dir, rather than the
root of the `containers` dir.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 1, 2018
@cgwalters
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2018
@miabbott
Copy link
Member Author

miabbott commented Oct 1, 2018

The aws-test job was failing because it couldn't find the JSON file it needed to copy to S3.

+ aws s3 cp --acl public-read /home/jenkins/workspace/coreos-rhcos-aws-test/aws-us-east-1.json s3://****/aws-us-east-1-tested.json

The user-provided path /home/jenkins/workspace/coreos-rhcos-aws-test/aws-us-east-1.json does not exist.

The root cause looks like this line:

+ rm -rf /home/jenkins/workspace/coreos-rhcos-aws-test

...so this should fix that.

@openshift-merge-robot openshift-merge-robot merged commit 2cb4704 into openshift:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants