Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline: don't send Slack update for dev pipelines #326

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

miabbott
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 27, 2018
Copy link
Contributor

@dm0- dm0- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that condition work inside the utility function itself so it doesn't need to be duplicated in all files?

@miabbott
Copy link
Member Author

Would that condition work inside the utility function itself so it doesn't need to be duplicated in all files?

I think it should. I'll rework the PR.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2018
@miabbott
Copy link
Member Author

Much easier this way. ⬆️

Thanks for the suggestion @dm0-

Copy link
Contributor

@dm0- dm0- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but it will still write some comments to the console log for build status changes that weren't important enough for a Slack notification. For consistency, maybe those should be skipped as well (e.g. by adding || params.DRY_RUN to the first condition in the function that returns), but it's minor enough that it probably won't matter.

@miabbott
Copy link
Member Author

@dm0- Yeah, you are right. I was too focused on the actual sending rather than the function as a whole. Pushed another update ⬆️

@dm0-
Copy link
Contributor

dm0- commented Sep 27, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2018
@miabbott
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 74c90c8 into openshift:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants