Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treecompose: properly record sha256sum #323

Merged
merged 1 commit into from
Sep 27, 2018
Merged

treecompose: properly record sha256sum #323

merged 1 commit into from
Sep 27, 2018

Conversation

miabbott
Copy link
Member

Using podman inspect to get the Id of a container locally, is not
the same as getting the Digest from the registry. This changes the
pipeline to use the value of Digest from the registry.

@miabbott
treecompose: properly record sha256sum
94f5e5f 
Using `podman inspect` to get the `Id` of a container locally, is not
the same as getting the `Digest` from the registry.  This changes the
pipeline to use the value of `Digest` from the registry.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 27, 2018
@miabbott
Copy link
Member Author

For example:

$ sudo podman inspect --format='{{.Id}}' registry.svc.ci.openshift.org/rhcos/os-maipo:latest
eb74aca9891a87b35395850df04eb01c17e30237c3b8b95d1f0d13ffbb23147a

$ sudo podman pull registry.svc.ci.openshift.org/rhcos/os-maipo@sha256:eb74aca9891a87b35395850df04eb01c17e30237c3b8b95d1f0d13ffbb23147a
Trying to pull registry.svc.ci.openshift.org/rhcos/os-maipo@sha256:eb74aca9891a87b35395850df04eb01c17e30237c3b8b95d1f0d13ffbb23147a...Failed
error pulling image "registry.svc.ci.openshift.org/rhcos/os-maipo@sha256:eb74aca9891a87b35395850df04eb01c17e30237c3b8b95d1f0d13ffbb23147a": unable to pull registry.svc.ci.openshift.org/rhcos/os-maipo@sha256:eb7s

$ sudo skopeo inspect docker://registry.svc.ci.openshift.org/rhcos/os-maipo:latest | sudo podman run --rm -i docker.io/miabbott/aht-tools jq '.Digest'
"sha256:513731b35f927bf3c954dec3074bdcf2c669150948598e717469584cca21fcb9"

$ sudo podman pull registry.svc.ci.openshift.org/rhcos/os-maipo@sha256:513731b35f927bf3c954dec3074bdcf2c669150948598e717469584cca21fcb9
Trying to pull registry.svc.ci.openshift.org/rhcos/os-maipo@sha256:513731b35f927bf3c954dec3074bdcf2c669150948598e717469584cca21fcb9...Getting image source signatures
Skipping fetch of repeat blob sha256:8aa098d03c3bc08d86d97a2c5e0a116953ff2ef7353413ecaa357485452cff72
Skipping fetch of repeat blob sha256:132fa26b77c6df2e77877b1f1786e863760f97093717b3b35be68c1d255680a2
Copying config sha256:eb74aca9891a87b35395850df04eb01c17e30237c3b8b95d1f0d13ffbb23147a
 823 B / 823 B [============================================================] 0s
Writing manifest to image destination
Storing signatures
eb74aca9891a87b35395850df04eb01c17e30237c3b8b95d1f0d13ffbb23147a

@cgwalters
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2018
@openshift-merge-robot openshift-merge-robot merged commit e516f9b into openshift:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@dm0- dm0- Awaiting requested review from dm0-

Assignees

@cgwalters cgwalters

Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miabbott @cgwalters @openshift-ci-robot @openshift-merge-robot