Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host-base.yaml: Add systemd-journal-gateway #321

Merged

Conversation

ashcrow
Copy link
Member

@ashcrow ashcrow commented Sep 27, 2018

@crawford let us know the context and we'll add it to the commit before merging.

At the time of writing this change will pull in systemd-journal-gateway-219-57.

@ashcrow
Copy link
Member Author

ashcrow commented Sep 27, 2018

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2018
@miabbott
Copy link
Member

I ran this through a test pipeline to get the diff:

ostree diff commit old: 1942146d20a246ab1561670515e69bedba9473dab5231027fa33bb9e443bfa92
ostree diff commit new: a9e7e43813624a07e7f286e2d39bf2d5fb4adcbd50a694ed9449eb27c3abf7b4
Added:
  gnutls-3.3.26-9.el7.x86_64
  libmicrohttpd-0.9.33-2.el7.x86_64
  nettle-2.7.1-8.el7.x86_64
  systemd-journal-gateway-219-57.el7.x86_64
  trousers-0.3.14-2.el7.x86_64

@crawford
Copy link
Contributor

The installer team wants to make use of journal-gatewayd to stream the logs off of the bootstrap node. This will provide a nice UX where the installer can show the progress of the pending installation and optionally dump logs for debugging purposes. This should get us that much closer to truly not requiring SSH.

@cgwalters
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2018
This change was requested by the installer team. It will allow
logs to stream from the bootstrap node providing a nice UX where
the installer can show the progress of the pending installation.

Signed-off-by: Steve Milner <[email protected]>
@ashcrow ashcrow force-pushed the add-journal-gatewayd branch from 967993d to a6a13a5 Compare September 27, 2018 16:50
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2018
@ashcrow
Copy link
Member Author

ashcrow commented Sep 27, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2018
@ashcrow
Copy link
Member Author

ashcrow commented Sep 27, 2018

Updated commit with information and dropped hold.

@cgwalters
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2018
@openshift-merge-robot openshift-merge-robot merged commit dfa7fb0 into openshift:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants