Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop LVM, use custom growpart wrapper #294

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Drop LVM, use custom growpart wrapper #294

merged 1 commit into from
Sep 17, 2018

Conversation

cgwalters
Copy link
Member

Closes: #293

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 17, 2018
@cgwalters
Copy link
Member Author

Requires: coreos/coreos-assembler#95

@cgwalters
Copy link
Member Author

Actually unless we backport coreos/fedora-coreos-config@0fdb511 the commits interlock - pushing one without the other will be broken.

dm0-
dm0- reviewed Sep 17, 2018
View reviewed changes
compose-post.sh Outdated
[Service]
ExecStart=/usr/libexec/coreos-growpart /
RemainAfterExit=yes
Before=sshd.service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Before= required to be under the [Unit] section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix this upstream.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently it's just ignored.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've submitted coreos/fedora-coreos-config#10.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coreos/fedora-coreos-config#11

And updated below ⬇️

@ashcrow
Copy link
Member

ashcrow commented Sep 17, 2018

@cgwalters Can that be backported in this PR set or do we need to keep them separate?

@cgwalters cgwalters force-pushed the no-lvm-custom-growpart branch from 8ef4cd0 to 5ca3e89 Compare September 17, 2018 17:34
@cgwalters
Copy link
Member Author

@cgwalters Can that be backported in this PR set or do we need to keep them separate?

Wouldn't hurt but wouldn't help either - the problem is once we build a new coreos-assembler:alpha. But we can just wait to do that until this merges.

@dm0-
Copy link
Contributor

dm0- commented Sep 17, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2018
@openshift-merge-robot openshift-merge-robot merged commit 66e2950 into openshift:master Sep 17, 2018
@lucab lucab mentioned this pull request Sep 21, 2018
Merged
@dustymabe dustymabe mentioned this pull request Sep 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dm0- dm0- dm0- approved these changes

@sdemos sdemos Awaiting requested review from sdemos

Assignees

@dm0- dm0-

Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cgwalters @ashcrow @dm0- @openshift-ci-robot @openshift-merge-robot