Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert revert: Remove docker #290

Merged
merged 2 commits into from
Sep 17, 2018

Conversation

ashcrow
Copy link
Member

@ashcrow ashcrow commented Sep 17, 2018

Go back to no docker.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 17, 2018
@cgwalters
Copy link
Member

OK by me, though for things like this in the future it may be good to add an installer change first that removes it (if [ -x /usr/bin/docker ]; then ostree admin unlock && rm /usr/bin/docker; fi or so early in ignition) - then once that lands successfully we can confidently make a change like this.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2018
@eparis
Copy link
Member

eparis commented Sep 17, 2018

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 38964af into openshift:master Sep 17, 2018
@wking
Copy link
Member

wking commented Sep 18, 2018

... for things like this in the future it may be good to add an installer change first that removes it (if [ -x /usr/bin/docker ]; then ostree admin unlock && rm /usr/bin/docker; fi or so early in ignition) - then once that lands successfully we can confidently make a change like this.

This would have missed the resizing thingie that Docker was giving us (#293), wouldn't it? Ideally there would be either CI here launching a cluster with the latest tested installer and the new RHCOS candidate. Maybe with allowed failures for now, so we could break out of deadlocks when we wanted to push through breaking changes. I don't know how hard that would be to set up, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants