Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Add tpm2_getcap to the initrd for Clevis TPM2 functionality #1660

Closed
wants to merge 1 commit into from

Conversation

c4rt0
Copy link
Contributor

@c4rt0 c4rt0 commented Nov 29, 2024

The tpm2_getcap binary is required for Clevis TPM2 operations but was missing from the initrd.

See: #1656

The tpm2_getcap binary is required for Clevis TPM2 operations but was missing from the initrd.

See: openshift#1656
Copy link
Contributor

openshift-ci bot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c4rt0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2024
@c4rt0 c4rt0 changed the title Add tpm2_getcap to the initrd for Clevis TPM2 functionality NO-JIRA: Add tpm2_getcap to the initrd for Clevis TPM2 functionality Nov 29, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 29, 2024
@openshift-ci-robot
Copy link

@c4rt0: This pull request explicitly references no jira issue.

In response to this:

The tpm2_getcap binary is required for Clevis TPM2 operations but was missing from the initrd.

See: #1656

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Nov 29, 2024

@c4rt0: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jlebon
Copy link
Member

jlebon commented Nov 29, 2024

What I meant by #1656 (comment) is that once coreos/ignition#1978 gets to RHEL, it should fix it here too. So I think instead we want to get that backported (actually to both Fedora and RHEL). And until that happens, we can denylist those tests.

@c4rt0
Copy link
Contributor Author

c4rt0 commented Nov 29, 2024

What I meant by #1656 (comment) is that once coreos/ignition#1978 gets to RHEL, it should fix it here too. So I think instead we want to get that backported (actually to both Fedora and RHEL). And until that happens, we can denylist those tests.

Ouch, cool - thanks for the clarification.
I will add any related tests to denylist instead.

@c4rt0 c4rt0 closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants