Enable new-app
#904
Merged
Enable new-app
#904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarterclayton
force-pushed
the
enable_new_app
branch
from
127109e to
436ff06
Compare
| @@ -140,24 +141,24 @@ func (g PipelineGroup) String() string { | |||
| return strings.Join(s, "+") | |||
| } | |||
|
|
|||
| const MaxServiceNameLen = 24 | |||
| const maxServiceNameLength = 24 | |||
There was a problem hiding this comment.
It seems like we need to set maxServiceNameLength to 19 so the name generator doesn't make it > 24 chars.
There was a problem hiding this comment.
Name generator handles that automatically.
There was a problem hiding this comment.
|
Looks good, only have the comments above |
smarterclayton
force-pushed
the
enable_new_app
branch
2 times, most recently
from
ce79b15 to
c6b3500
Compare
|
[merge] |
smarterclayton
force-pushed
the
enable_new_app
branch
from
c6b3500 to
c84473f
Compare
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1015/) (Image: devenv-fedora_725) |
|
[Test]ing while waiting on the merge queue |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1015/) |
|
Evaluated for origin up to c84473f |
jpeeler
pushed a commit
to jpeeler/origin
that referenced
this pull request
Jun 15, 2017
…service-catalog/' changes from c91fecb..1bfff53 1bfff53 instance never provisioned should just delete (openshift#891) 1ae26db Adding a fake broker server (openshift#928) 6403076 docs: fix quoting issue, clarify naming in auth.md (openshift#931) 8ac0775 Merge branch 'pr/927' 02af952 Merge branch 'pr/876' 2aa84f9 add Jenkins badge to README 0c08788 Brokers must have at least one service (openshift#930) cbfa39b Add PodPreset support (openshift#917) 0d9b810 refactor Jenkins GitHub status postback to work on non-PR commits (openshift#916) 066159d Converting the AuthSecret field to a union AuthInfo type (openshift#877) 203af5c Add leader election namespace configuration (openshift#920) 5831502 Add example JSON schema to controller unit tests (openshift#918) b78ab99 Fix usage of finalizers (openshift#894) d3d29f0 Enable pprof in controller-manager (openshift#896) f4233a0 Correct parameter schema support (openshift#912) 05c6f00 bump image tags from v0.0.8 to v0.0.9 (openshift#910) 97d278a Add support for OSB parameter schemas (openshift#822) 3e4120e Fix nil dereference panic on request timeout (openshift#906) d8c7494 Add feature gate for audit options in helm chart (openshift#904) 89ce1cd Decompose controller unit tests (openshift#899) a1e83b2 Add e2e for walkthrough (openshift#832) 4679685 Add support for audit log options (openshift#897) 262a94f Do not allow updates to an object if asynchronous operation is in progress (openshift#853) 7295dad Validate that a ServiceClass must have at least one plan (openshift#879) 9db9fa4 Decompose controller.go (openshift#893) c3ea9bd Nits in our types (openshift#854) 1d8280a bump tags from v0.0.7 to v0.0.8 (openshift#892) 5e6925d Clean up the OSB client (openshift#888) fe6aee9 cleaning up logs and adding more log detail (openshift#874) f41516f Detect if a TPR update represents a soft delete (openshift#836) 9ce99f3 Add functions on Makefile for build and tag REVERT: c91fecb Merge pull request openshift#1 from jpeeler/origin-build REVERT: 55ccf3d origin build: add _output to .gitignore REVERT: 8352e14 origin build: make build-go and build-cross work REVERT: d969641 origin build: modify hard coded path REVERT: 30000cc origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 1bfff53
jpeeler
pushed a commit
to jpeeler/origin
that referenced
this pull request
Jun 15, 2017
…service-catalog/' changes from c91fecb..568a7b9 568a7b9 origin build: add origin tooling 1bfff53 instance never provisioned should just delete (openshift#891) 1ae26db Adding a fake broker server (openshift#928) 6403076 docs: fix quoting issue, clarify naming in auth.md (openshift#931) 8ac0775 Merge branch 'pr/927' 02af952 Merge branch 'pr/876' 2aa84f9 add Jenkins badge to README 0c08788 Brokers must have at least one service (openshift#930) cbfa39b Add PodPreset support (openshift#917) 0d9b810 refactor Jenkins GitHub status postback to work on non-PR commits (openshift#916) 066159d Converting the AuthSecret field to a union AuthInfo type (openshift#877) 203af5c Add leader election namespace configuration (openshift#920) 5831502 Add example JSON schema to controller unit tests (openshift#918) b78ab99 Fix usage of finalizers (openshift#894) d3d29f0 Enable pprof in controller-manager (openshift#896) f4233a0 Correct parameter schema support (openshift#912) 05c6f00 bump image tags from v0.0.8 to v0.0.9 (openshift#910) 97d278a Add support for OSB parameter schemas (openshift#822) 3e4120e Fix nil dereference panic on request timeout (openshift#906) d8c7494 Add feature gate for audit options in helm chart (openshift#904) 89ce1cd Decompose controller unit tests (openshift#899) a1e83b2 Add e2e for walkthrough (openshift#832) 4679685 Add support for audit log options (openshift#897) 262a94f Do not allow updates to an object if asynchronous operation is in progress (openshift#853) 7295dad Validate that a ServiceClass must have at least one plan (openshift#879) 9db9fa4 Decompose controller.go (openshift#893) c3ea9bd Nits in our types (openshift#854) 1d8280a bump tags from v0.0.7 to v0.0.8 (openshift#892) 5e6925d Clean up the OSB client (openshift#888) fe6aee9 cleaning up logs and adding more log detail (openshift#874) f41516f Detect if a TPR update represents a soft delete (openshift#836) 9ce99f3 Add functions on Makefile for build and tag REVERT: c91fecb Merge pull request openshift#1 from jpeeler/origin-build REVERT: 55ccf3d origin build: add _output to .gitignore REVERT: 8352e14 origin build: make build-go and build-cross work REVERT: d969641 origin build: modify hard coded path REVERT: 30000cc origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 568a7b9dbdc4fdd1fabffdd52af030ec73124b89
sjenning
pushed a commit
to sjenning/origin
that referenced
this pull request
Jan 5, 2018
[3.6][Backport] Bug 1481147 - Fix default pod image for network diagnostics
jpeeler
pushed a commit
to jpeeler/origin
that referenced
this pull request
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.