Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Project Template #8

Closed
wants to merge 5 commits into from
Closed

[WIP] Project Template #8

wants to merge 5 commits into from

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Aug 12, 2014

This is an WIP of the Project Template work.
The code below define the Project structs and implement parameters substitution for the JSON.

TODO:

  • Add ServiceLinks substitution

@mfojtik mfojtik changed the title Initial addition of project template [WIP] Project Template Aug 12, 2014
@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 12, 2014

@smarterclayton fyi, I know it will take a while for this to be the final version (specs) and a lot of this will go into Kubernetes instead of this repo, but just want to track the progress on the params substitution.

@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 12, 2014

@VojtechVitek ^^

@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 13, 2014

Changelog

  • Make getting Parameter more effective by converting the Parameters to Hash
  • The PValue#Substitute function now modifies the value of itself
  • Added ServiceLinks to SubstituteEnvValues
  • Added rand.Seed to ProcessParameters
  • Added godocs

@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 13, 2014

Changelog

  • Added ServiceLinks resolving in terms that environment variables exported by the ServiceLink are copied into target service.

smarterclayton
smarterclayton reviewed Aug 13, 2014
View reviewed changes
pkg/project/generator.go
@@ -0,0 +1,130 @@
package project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would change the package on this to be "template"

@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 14, 2014

Sorry guys, I need to close this PR in favor of #18 as making the repo public screwed somehow my branches (pushing into the old repo does not seem to affect this PR).

@mfojtik mfojtik closed this Aug 14, 2014
ironcladlou referenced this pull request in ironcladlou/origin Sep 26, 2014
@pmorie
Merge pull request #8 from pmorie/deploy-trigger-wip
5c6c31b 
Add GenerateDeploymentConfig method to client
soltysh referenced this pull request in soltysh/origin Nov 17, 2014
@fabianofranz
Merge pull request #8 from soltysh/rebase_kube_upstream
4071624 
Fixing tests: image, config, build, deploy, project
@0xmichalis 0xmichalis mentioned this pull request Dec 19, 2015
Merged
sttts referenced this pull request in sttts/origin Dec 8, 2016
@ncdc
Merge pull request #8 from sttts/sttts-1.5-rebase-master-tests
d40bfc2 
Make handler_test.go green. TODO deads liggitt review
@knobunc knobunc mentioned this pull request May 31, 2017
Closed
@micah micah mentioned this pull request Jan 16, 2018
Closed
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Feb 1, 2018
@pmorie
Merge pull request openshift#8 from duglin/moreREADME
620c042 
More edits to readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfojtik @ncdc @smarterclayton