WRKLDS-605: e2e: Config v1 client shim for static configuration manifests with read-only operations #27714
Conversation
openshift-ci
bot
added
do-not-merge/work-in-progress
ingvagabund
force-pushed
the
e2e-env-with-config.openshift.io
branch
2 times, most recently
from
c17604f to
c8be741
Compare
ingvagabund
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@ingvagabund: This pull request references WRKLDS-605 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@ingvagabund: This pull request references WRKLDS-605 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ingvagabund: This pull request references WRKLDS-605 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ingvagabund
force-pushed
the
e2e-env-with-config.openshift.io
branch
2 times, most recently
from
67b4bd9 to
aa75bd1
Compare
openshift-merge-robot
added
the
needs-rebase
|
@ingvagabund: This pull request references WRKLDS-605 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ingvagabund: This pull request references WRKLDS-605 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ingvagabund: This pull request references WRKLDS-605 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ingvagabund: This pull request references WRKLDS-605 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ingvagabund: This pull request references WRKLDS-605 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ingvagabund: This pull request references WRKLDS-605 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ingvagabund
force-pushed
the
e2e-env-with-config.openshift.io
branch
from
aa75bd1 to
34d7491
Compare
openshift-merge-robot
removed
the
needs-rebase
ingvagabund
force-pushed
the
e2e-env-with-config.openshift.io
branch
2 times, most recently
from
84c6ce4 to
bd8e3ed
Compare
|
We can either have the envs as we have now. Or, create one huge json string passed through a single env variable. |
|
@ingvagabund: This pull request references WRKLDS-605 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-robot
added
the
needs-rebase
ingvagabund
force-pushed
the
e2e-env-with-config.openshift.io
branch
from
bd8e3ed to
31b76a6
Compare
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
failure due to openshift/release#37909 - should be ok now |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/hold Revision c568b58 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@ingvagabund: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
|
/cherrypick release-4.13 |
|
@ingvagabund: #27714 failed to apply on top of branch "release-4.13": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ests with read-only operations (openshift#27714) * e2e: inject static config manifests if present * Apply request on the level of individual config v1 kinds * Add config.openshift.io/v1 Networks client shim * Collect static manifests only when the manifest directory is not empty * Make make verify happy * Address comments Add support for field selectors for List and Watch requests Fix naming * Document expected content of the static manifest directory * Discovery shim for config.openshift.io/v1 * Check abundance of events, check existence of a real object in a list * Unit test config v1 shim discovery methods * make update-gofmt * Return early without config v1 kinds * Do not use ginkgo.Expect for checking collectConfigManifestsFromDir error The ginkgo handler is not yet initialized properly * Set staticConfigManifestDir for NewCLIWithFramework * Update annotate rules to exclude [sig-network][Feature:EgressIP][apigroup:operator.openshift.io] [internal-targets]
…ests with read-only operations (openshift#27714) * e2e: inject static config manifests if present * Apply request on the level of individual config v1 kinds * Add config.openshift.io/v1 Networks client shim * Collect static manifests only when the manifest directory is not empty * Make make verify happy * Address comments Add support for field selectors for List and Watch requests Fix naming * Document expected content of the static manifest directory * Discovery shim for config.openshift.io/v1 * Check abundance of events, check existence of a real object in a list * Unit test config v1 shim discovery methods * make update-gofmt * Return early without config v1 kinds * Do not use ginkgo.Expect for checking collectConfigManifestsFromDir error The ginkgo handler is not yet initialized properly * Set staticConfigManifestDir for NewCLIWithFramework * Update annotate rules to exclude [sig-network][Feature:EgressIP][apigroup:operator.openshift.io] [internal-targets]
…ests with read-only operations (openshift#27714) * e2e: inject static config manifests if present * Apply request on the level of individual config v1 kinds * Add config.openshift.io/v1 Networks client shim * Collect static manifests only when the manifest directory is not empty * Make make verify happy * Address comments Add support for field selectors for List and Watch requests Fix naming * Document expected content of the static manifest directory * Discovery shim for config.openshift.io/v1 * Check abundance of events, check existence of a real object in a list * Unit test config v1 shim discovery methods * make update-gofmt * Return early without config v1 kinds * Do not use ginkgo.Expect for checking collectConfigManifestsFromDir error The ginkgo handler is not yet initialized properly * Set staticConfigManifestDir for NewCLIWithFramework * Update annotate rules to exclude [sig-network][Feature:EgressIP][apigroup:operator.openshift.io] [internal-targets]
Implement a config client shim that allows to intersect requests from a client and replace requests over static manifests with read-only operation over the manifests. The request replacement is no-op for object outside the of static manifest directory. In case a mutation request is required over static manifests, an error is returned.
The static manifests directory is pointed to through
STATIC_CONFIG_MANIFEST_DIRenvironment variable. Currently only manifests from [infrastructure|network].config.openshift.io/v1 are supported as static manifests.Exemplary manifests for MicroShift deployment: