Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 64541: Add more kubectl auth reconcile flags #20281

Merged
merged 2 commits into from
Jul 30, 2018
Merged

UPSTREAM: 64541: Add more kubectl auth reconcile flags #20281

merged 2 commits into from
Jul 30, 2018

Conversation

mrogers950
Copy link
Contributor

@mrogers950 mrogers950 commented Jul 11, 2018 •
edited
Loading

A pick for kubernetes/kubernetes#64541 to go along with the --dry-run addition, they were split between 1.11 and 1.12.
@juanvallejo @deads2k

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 11, 2018
@bparees bparees removed their request for review July 11, 2018 01:33
@juanvallejo
Copy link
Contributor

@mrogers950

A carry for kubernetes/kubernetes#64541

why a carry instead of a pick?

@mrogers950
Copy link
Contributor Author

mrogers950 commented Jul 11, 2018 •
edited
Loading

@juanvallejo

why a carry instead of a pick?

Don't know, I guess that means I should do a pick then :)

@mrogers950 mrogers950 changed the title UPSTREAM <carry>: Add more kubectl auth reconcile flags UPSTREAM 64541: Add more kubectl auth reconcile flags Jul 11, 2018
@mrogers950
Copy link
Contributor Author

@juanvallejo thanks, updated.

@juanvallejo
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2018
@mrogers950 mrogers950 requested a review from deads2k July 12, 2018 18:08
@smarterclayton
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, mrogers950, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2018
@enj enj changed the title UPSTREAM 64541: Add more kubectl auth reconcile flags UPSTREAM: 64541: Add more kubectl auth reconcile flags Jul 30, 2018
@mrogers950
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 1c17e88 into openshift:master Jul 30, 2018
@enj enj mentioned this pull request Aug 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@juanvallejo juanvallejo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrogers950 @juanvallejo @smarterclayton @openshift-ci-robot @openshift-merge-robot