Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shim build config to oc adm drain #17850

Closed
wants to merge 2 commits into from
Closed

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Dec 18, 2017

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1525340

@deads2k @smarterclayton if this is reasonable, I will open the upstream PR.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Dec 18, 2017
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 18, 2017
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@soltysh
Copy link
Contributor

soltysh commented Dec 18, 2017

Just make sure to open the upstream PR and replace those 0's in the commit title 😉

@openshift-ci-robot
Copy link

@mfojtik: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/unit 9c500d7 link /test unit
ci/openshift-jenkins/extended_conformance_gce 9c500d7 link /test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install 9c500d7 link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mfojtik
Copy link
Contributor Author

mfojtik commented Dec 18, 2017

/cherrypick release-3.8

@openshift-cherrypick-robot

@mfojtik: once the present PR merges, I will cherry-pick it on top of release-3.8 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor

deads2k commented Dec 18, 2017

I think that @juanvallejo has a good explanation of the general challenge here: kubernetes/kubernetes#56864. In the general case, adding a factory method doesn't help.

@deads2k
Copy link
Contributor

deads2k commented Dec 18, 2017

/hold

I think we should take kubernetes/kubernetes#56864 instead.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2017
@mfojtik
Copy link
Contributor Author

mfojtik commented Dec 18, 2017

@deads2k agree, mea culpa that I was not looking for open PR's

@mfojtik mfojtik closed this Dec 18, 2017
@mfojtik mfojtik deleted the fix-oc-drain branch September 5, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants