-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speculative bump of gRPC to 1.2.1 to test for hangs #17723
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@smarterclayton was the intent here mimic the changes in etcd-io/etcd#8867 ? I think we will require bump of etcd, don't think just the grpc bump will do the trick? |
+1 for etcd bump, which seems easier, esp. that we don't carry any patches anymore, iirc |
/test all |
@mfojtik: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I'm not sure we should be bumping the Kube gRPC version. The risk of breaking the node is too high. |
@smarterclayton compilable version of #17720... i also bumped the grpc vendored by etcd.
@liggitt @soltysh FYI