Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fast when request to /.well-known/oauth-authorization-server fails #17606

Merged

Conversation

php-coder
Copy link
Contributor

Improves error reporting. See here for more details: #17574 (comment)

Prior this change hack/test-cmd.sh could fail with the error:

error: Missing configuration - verify you have provided the correct host and port and that the server is currently running.

Now, the message has more details:

error: couldn't get https://10.34.129.148:28443/.well-known/oauth-authorization-server: unexpected status 403 were returned - verify you have provided the correct host and port and that the server is currently running.

PTAL @enj @simo5

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2017
@enj
Copy link
Contributor

enj commented Dec 5, 2017

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2017
@php-coder
Copy link
Contributor Author

The failing test confirms a new behavior:

=== BEGIN TEST CASE ===
hack/test-cmd.sh:107: executing 'oc login --server='https://172.17.0.2:28443' --certificate-authority='/tmp/openshift/test-cmd/openshift.local.config/master/ca.crt' -u test-user -p anything' expecting success
FAILURE after 0.203s: hack/test-cmd.sh:107: executing 'oc login --server='https://172.17.0.2:28443' --certificate-authority='/tmp/openshift/test-cmd/openshift.local.config/master/ca.crt' -u test-user -p anything' expecting success: the command returned the wrong error code
There was no output from the command.
Standard error from the command:
error: couldn't get https://172.17.0.2:28443/.well-known/oauth-authorization-server: unexpected response status 403 - verify you have provided the correct host and port and that the server is currently running.
error: couldn't get https://172.17.0.2:28443/.well-known/oauth-authorization-server: unexpected response status 403
=== END TEST CASE ===

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2017
@php-coder
Copy link
Contributor Author

Only gofmt was run.

@enj
Copy link
Contributor

enj commented Dec 6, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, php-coder

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@enj
Copy link
Contributor

enj commented Dec 6, 2017

/retest

@php-coder
Copy link
Contributor Author

Test flake #17631
/test extended_conformance_gce

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17217, 17597, 17606).

@openshift-merge-robot openshift-merge-robot merged commit e9bb78b into openshift:master Dec 6, 2017
@php-coder php-coder deleted the test_response_code branch December 6, 2017 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants