UPSTREAM: 50934: Skip non-update endpoint updates

[sjenning]

Node performance impact fix for endpoints controller. Skips no-op service updates on pod that have not changed in a way that impacts endpoints.

xref kubernetes/kubernetes#50934 and kubernetes/kubernetes#51144

@joelsmith @derekwaynecarr @eparis @smarterclayton

[derekwaynecarr]

/assign @derekwaynecarr

[derekwaynecarr]

/approve
/lgtm

need to make ci happy, but its not happy anywhere right now.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[sjenning]

3 are flakes:
extended_templates failing on #15901
extended_conformance_install_update failing on #15874
end_to_end failed on docker-registry deployment timeout

extended_conformance_gce failed on [k8s.io] Proxy version v1 should proxy through a service and a pod and might be something to look at. Retesting to see if it errors on the same test again.

/retest

[smarterclayton]

I'm seeing errors that look like endpoints being broken or delayed. Removing label.

[sjenning]

@smarterclayton which errors in particular? The Proxy version v1 should proxy through a service and a pod test?

[sjenning]

@smarterclayton nm, upstream failure just came in for the same test kubernetes/kubernetes#51128

[joelsmith]

/test extended_conformance_install_update

[sjenning]

@smarterclayton Fix from upstream is now pushed onto the PR. Thanks @joelsmith 👍

All tests are green now. Can I get lgtm again?

[derekwaynecarr]

/lgtm

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sjenning

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• vendor/k8s.io/kubernetes/pkg/controller/OWNERS [derekwaynecarr]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[openshift-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[sjenning]

/retest

[sjenning]

@joelsmith might have another legit e2e test failure here:

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/15888/test_pull_request_origin_extended_conformance_gce/6435/

I'm retesting in case it was a flake but keeping a link to the failure in case we need to reference it.

[openshift-ci-robot]

@sjenning: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_conformance_gce	7ddf7be	link	/test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 15870, 15888, 15788, 15907, 15936)