Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registry: reenable logstash formatter #15423

Merged
merged 2 commits into from
Jul 31, 2017
Merged

registry: reenable logstash formatter #15423

merged 2 commits into from
Jul 31, 2017

Conversation

miminar
Copy link

@miminar miminar commented Jul 24, 2017

Resolves #15296

Michal Minář added 2 commits July 24, 2017 12:29
bump(github.com/bshuster-repo/logrus-logstash-hook): 0e6d502573042a65…
49365ca 
…63419fbcce4f284600bfe929

A dependency for Sirupsen.logrus to enable logstash formatter.

Signed-off-by: Michal Minář <[email protected]>
registry: reenable logstash formatter
3054177 
Resolves openshift#15296

Signed-off-by: Michal Minář <[email protected]>
@miminar
Copy link
Author

miminar commented Jul 24, 2017

@dmage PTAL
@mfojtik FYI

@miminar
Copy link
Author

miminar commented Jul 24, 2017 •
edited
Loading

[test][testextended][extended:core(ImagePrun|registry)]

@miminar miminar mentioned this pull request Jul 24, 2017
Closed
@mfojtik
Copy link
Contributor

mfojtik commented Jul 24, 2017

LGTM

/approve

@miminar
Copy link
Author

miminar commented Jul 24, 2017

Flake #15432. re-[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to 3054177

@openshift-merge-robot openshift-merge-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 24, 2017
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/910/) (Base Commit: 74121fa) (PR Branch Commit: 3054177) (Extended Tests: core(ImagePrun|registry))

@miminar
Copy link
Author

miminar commented Jul 25, 2017

Flake #15452 for the extended test. Flake #15453 for the regular test.

@miminar
Copy link
Author

miminar commented Jul 25, 2017

re-[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 3054177

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3486/) (Base Commit: f2604f9) (PR Branch Commit: 3054177)

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2017
@bparees
Copy link
Contributor

bparees commented Jul 25, 2017

/assign @mfojtik

@bparees bparees removed their assignment Jul 25, 2017
@0xmichalis
Copy link
Contributor

/test all

@miminar
Copy link
Author

miminar commented Jul 31, 2017

@mfojtik lgty? :)

@mfojtik
Copy link
Contributor

mfojtik commented Jul 31, 2017

/lgtm @miminar but needs to have green tests

@miminar
Copy link
Author

miminar commented Jul 31, 2017

/retest

@miminar miminar mentioned this pull request Jul 31, 2017
Merged
@mfojtik
Copy link
Contributor

mfojtik commented Jul 31, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, miminar

Associated issue: 15296

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 15537, 15423)

openshift-merge-robot added a commit that referenced this pull request Jul 31, 2017
@openshift-merge-robot
Merge pull request #15423 from miminar/restore-logstash-formatting
5e6147b 
Automatic merge from submit-queue (batch tested with PRs 15537, 15423)

registry: reenable logstash formatter

Resolves #15296
@openshift-merge-robot openshift-merge-robot merged commit 5e6147b into openshift:master Jul 31, 2017
@miminar miminar deleted the restore-logstash-formatting branch October 10, 2017 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfojtik mfojtik

@eparis eparis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@miminar @mfojtik @openshift-bot @bparees @0xmichalis @openshift-merge-robot @eparis @openshift-ci-robot