Template service broker documentation and logging updates #14318
Conversation
jim-minter
force-pushed
the
trello132-broker-sar-updates
branch
2 times, most recently
from
719f213 to
ee9ee8e
Compare
| @@ -244,6 +287,9 @@ func (c *TemplateInstanceController) provision(templateInstance *templateapi.Tem | |||
| return errs[0] | |||
| } | |||
|
|
|||
| // We add an OwnerReference to all objects we create - this is also needed | |||
| // by the template service broker for cleanup. TODO: what about any objects | |||
| // created by the templateinstance in other namespaces? | |||
pkg/template/servicebroker/bind.go
Outdated
| func (b *Broker) Bind(instanceID, bindingID string, breq *api.BindRequest) *api.Response { | ||
| glog.V(4).Infof("Template service broker: Bind") |
There was a problem hiding this comment.
print the instanceid and binding id?
| func (b *Broker) Catalog() *api.Response { | ||
| glog.V(4).Infof("Template service broker: Catalog") |
There was a problem hiding this comment.
maybe at least print the list of namespaces that it's fetching templates from. this will help when someone says "but it's not retrieving all my templates"
There was a problem hiding this comment.
have added this to the service broker startup log message - unless you really want it logged on every time a catalog call is made (and loglevel >= 4)?
| // TODO: currently the spec does not allow for user information to be | ||
| // provided on Deprovision, so little authorization can be carried out. | ||
|
|
||
| glog.V(4).Infof("Template service broker: Deprovision") |
| // TODO: currently the spec does not allow for user information to be | ||
| // provided on LastOperation, so little authorization can be carried out. | ||
|
|
||
| glog.V(4).Infof("Template service broker: LastOperation") |
| func (b *Broker) Provision(instanceID string, preq *api.ProvisionRequest) *api.Response { | ||
| glog.V(4).Infof("Template service broker: Provision") |
pkg/template/servicebroker/unbind.go
Outdated
| func (b *Broker) Unbind(instanceID, bindingID string) *api.Response { | ||
| glog.V(4).Infof("Template service broker: Unbind") |
|
couple nits related to what's being logged but mostly looks great. The readme is especially helpful imho. |
jim-minter
force-pushed
the
trello132-broker-sar-updates
branch
from
ee9ee8e to
2593143
Compare
|
@bparees updated and pushed |
|
[merge][severity:bug] |
|
[Test]ing while waiting on the merge queue |
openshift-bot
added
the
needs-rebase
jim-minter
force-pushed
the
trello132-broker-sar-updates
branch
from
2593143 to
3b0f19f
Compare
|
rebased, please remerge |
|
Evaluated for origin test up to 3b0f19f |
openshift-bot
removed
the
needs-rebase
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1791/) (Base Commit: a1dffba) |
|
flake #13980, please remerge |
|
[merge][severity:bug] |
1 similar comment
|
[merge][severity:bug] |
|
Evaluated for origin merge up to 3b0f19f |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/829/) (Base Commit: 060f5e5) (Extended Tests: bug) (Image: devenv-rhel7_6280) |
Documentation and logging updates as a follow-up to #14216
@openshift/devex ptal