Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to notice upstream changes in group perferred versions #14016

Merged
merged 1 commit into from
May 9, 2017
Merged

Add test to notice upstream changes in group perferred versions #14016

merged 1 commit into from
May 9, 2017

Conversation

sttts
Copy link
Contributor

@sttts sttts commented May 3, 2017 •
edited
Loading

@sttts sttts mentioned this pull request May 3, 2017
Merged
13 tasks
@sttts
Copy link
Contributor Author

sttts commented May 3, 2017

[test]

liggitt
liggitt reviewed May 3, 2017
View reviewed changes
pkg/cmd/server/kubernetes/master/master_config_test.go Outdated
@@ -25,6 +26,31 @@ import (
configapi "github.com/openshift/origin/pkg/cmd/server/api"
)

var expectedGroupPreferredVersions []string = []string{
"apps/v1beta1,authentication.k8s.io/v1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one version per line for readability

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the order isn't significant (I can't remember if it is), then sort both lists

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we get back from AllPreferredGroupVersions is sorted already. Will add a comment above to keep it sorted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@liggitt
Copy link
Contributor

liggitt commented May 3, 2017

a couple nits, LGTM otherwise

@sttts sttts force-pushed the sttts-grouppreferredversions-test branch from 2d5274d to 53d2d11 Compare May 9, 2017 05:05
@sttts
Copy link
Contributor Author

sttts commented May 9, 2017

[merge]

@sttts
Copy link
Contributor Author

sttts commented May 9, 2017

Flake #12927

@sttts
Copy link
Contributor Author

sttts commented May 9, 2017

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 53d2d11

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1248/) (Base Commit: 5468a46)

@sttts
Copy link
Contributor Author

sttts commented May 9, 2017

[merge]

1 similar comment
@deads2k
Copy link
Contributor

deads2k commented May 9, 2017

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented May 9, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1248/) (Base Commit: 5468a46) (Image: devenv-rhel7_6217)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 53d2d11

@deads2k deads2k added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2017
@deads2k
Copy link
Contributor

deads2k commented May 9, 2017

test fixes. approved.

@openshift-bot openshift-bot merged commit 3e446c7 into openshift:master May 9, 2017
@sttts sttts deleted the sttts-grouppreferredversions-test branch May 9, 2017 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sttts @liggitt @openshift-bot @deads2k