Update logging in our deployment controllers #13762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
Signed-off-by: Michail Kargakis <[email protected]>
|
Evaluated for origin test up to 0fe3131 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/748/) (Base Commit: bf9854f) |
|
LGTM [merge] |
|
#13811 [merge] |
mfojtik
approved these changes
Apr 19, 2017
| return nil, err | ||
| } | ||
| if !exists { | ||
| glog.Infof("Deployment config %q has been deleted", key) | ||
| glog.V(4).Infof("Deployment config %q has been deleted", key) |
There was a problem hiding this comment.
nit: DeploymentConfig (to be consistent)
|
#13812 [merge] |
|
#13814 [merge] |
|
#12072 [merge] |
|
#13823 [merge] |
1 similar comment
|
#13823 [merge] |
|
#13823 [merge] |
|
[merge]
…On Wed, Apr 19, 2017 at 7:53 PM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/388/)
(Base Commit: 846289d
<846289d>
)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#13762 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p_1pmzT_OQ_fu-lOjW4ewwmR4aLDks5rxp56gaJpZM4M9DqQ>
.
|
|
#13814 [merge] |
|
#13846 [merge] |
|
#13846 [merge] |
|
[merge] |
|
#9397 [merge] |
|
Evaluated for origin merge up to 0fe3131 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/432/) (Base Commit: c106caf) (Image: devenv-rhel7_6171) |
|
|
|
very nice. |
|
Wow
…On Mon, Apr 24, 2017 at 7:23 AM, Michal Fojtik ***@***.***> wrote:
very nice.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#13762 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p6wja17kHnX5GNG9XJIGNh_hWAeIks5rzIZPgaJpZM4M9DqQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13761
While here this also fixes #11854
@ncdc @mfojtik