Rename all controller.go to be easily distinguishable in logs #13699
Conversation
|
[test] |
|
I like the idea of renaming them. |
|
+1 on renaming them and +1 on letting us rename our own controllers :) |
Didn't someone (who can remain nameless), force us to make all the filenames the same? Something about go-like instead of java-like maybe? |
That makes debugging any remote issue with controllers almost impossible. That's because with the glog limitation we only see the go filename, but no path to it. K8S already did that change, if we need another argument of this sort ;) |
openshift-bot
added
the
needs-rebase
soltysh
force-pushed
the
rename_controllers
branch
from
a9e3755 to
c99ee02
Compare
soltysh
changed the title
|
Evaluated for origin test up to c99ee02 |
|
Since the rebase landed, I'd like to push this forward as well. Any objections? @bparees since you complained a bit 😉 |
openshift-bot
removed
the
needs-rebase
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1076/) (Base Commit: 0bf8c01) |
|
It's going to merge conflict some people but it shouldn't be too bad. Go for it. I'm certainly in favor of the rename in general. |
|
[merge] |
I know, myself included, since I'm modifying the image controller, switching to shared informers. |
|
[merge] |
|
Evaluated for origin merge up to c99ee02 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/535/) (Base Commit: 7a4496d) (Image: devenv-rhel7_6199) |
We need this for ease of debugging, and it should be merged for 3.6, still.
Since I don't want to mess people yet, I'll wait for at least the rebase to land. @csrwng I've heard you're re-factoring build controllers so if you could pick the build part that will be also great and won't interfere with your changes @bparees mentioned.
@sttts @ncdc @smarterclayton @liggitt @deads2k @mfojtik @knobunc @danwinship fyi
Currently blocked by #13653