Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent jenkins from being killed prematurely #12134

Merged
merged 1 commit into from
Dec 9, 2016
Merged

Prevent jenkins from being killed prematurely #12134

merged 1 commit into from
Dec 9, 2016

Conversation

wtrocki
Copy link
Contributor

@wtrocki wtrocki commented Dec 4, 2016

What was done

Changed initialDelaySeconds for livenessProbe in openshift-persistent template

Definition of the problem

Jenkins template livenessProbe initial delay is too small and it's killing jenkins before it starts.
Recent jenkins image requires lots of time to start on PV.
On my machine (MacPro 2015) it takes up to 6 minutes.

Dec 04, 2016 11:20:33 PM jenkins.InitReactorRunner$1 onAttained
INFO: Started initialization
Dec 04, 2016 11:26:05 PM jenkins.InitReactorRunner$1 onAttained
INFO: Listed all plugins

Steps to replicate

oc cluster up
oc new-app -f ./jenkins-persistent-template.json

livenessProbe with only 2 minutes initialDelaySeconds is IMHO to small. I tested this on different machines etc.

@bparees
Copy link
Contributor

bparees commented Dec 6, 2016

you will need to run hack/update-generated-bootstrap-bindata.sh

@bparees
Copy link
Contributor

bparees commented Dec 6, 2016

@wtrocki please squash your commits and i'll merge it

@bparees
Copy link
Contributor

bparees commented Dec 6, 2016

actually, update jenkins-ephemeral too, i'd like to keep them in sync.

Changed initialDelaySeconds for livenessProbe in openshift-persistent template
@wtrocki
Copy link
Contributor Author

wtrocki commented Dec 7, 2016

FIXED. Thanks for quick review!

@bparees
Copy link
Contributor

bparees commented Dec 7, 2016

[merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@bparees
Copy link
Contributor

bparees commented Dec 7, 2016 via email

@bparees
Copy link
Contributor

bparees commented Dec 7, 2016

flake #9285
[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 9e829c1

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12117/) (Base Commit: 2bd6ed4)

@bparees
Copy link
Contributor

bparees commented Dec 8, 2016

flake #8571
[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 9e829c1

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 9, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12179/) (Base Commit: f2427b8) (Image: devenv-rhel7_5512)

@openshift-bot openshift-bot merged commit 1b65aa5 into openshift:master Dec 9, 2016
@wtrocki wtrocki deleted the patch-1 branch December 9, 2016 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants