Skip to content

Commit

Permalink
admission: enable webhooks by default
Browse files Browse the repository at this point in the history
  • Loading branch information
sttts committed Sep 6, 2018
1 parent 03c094b commit 9599d4c
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 7 deletions.
14 changes: 8 additions & 6 deletions pkg/cmd/server/origin/admission/chain_builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,17 @@ import (
"k8s.io/apimachinery/pkg/util/sets"
"k8s.io/apiserver/pkg/admission"
"k8s.io/apiserver/pkg/admission/plugin/namespace/lifecycle"
mutatingwebhook "k8s.io/apiserver/pkg/admission/plugin/webhook/mutating"
validatingwebhook "k8s.io/apiserver/pkg/admission/plugin/webhook/validating"
"k8s.io/apiserver/pkg/apis/apiserver"
noderestriction "k8s.io/kubernetes/plugin/pkg/admission/noderestriction"
"k8s.io/kubernetes/plugin/pkg/admission/noderestriction"
expandpvcadmission "k8s.io/kubernetes/plugin/pkg/admission/storage/persistentvolume/resize"
storageclassdefaultadmission "k8s.io/kubernetes/plugin/pkg/admission/storage/storageclass/setdefault"

oadmission "github.com/openshift/origin/pkg/cmd/server/admission"
configapi "github.com/openshift/origin/pkg/cmd/server/apis/config"
configapilatest "github.com/openshift/origin/pkg/cmd/server/apis/config/latest"
imagepolicy "github.com/openshift/origin/pkg/image/apiserver/admission/apis/imagepolicy"
"github.com/openshift/origin/pkg/image/apiserver/admission/apis/imagepolicy"
imageadmission "github.com/openshift/origin/pkg/image/apiserver/admission/limitrange"
ingressadmission "github.com/openshift/origin/pkg/network/apiserver/admission"
overrideapi "github.com/openshift/origin/pkg/quota/apiserver/admission/apis/clusterresourceoverride"
Expand Down Expand Up @@ -99,8 +101,8 @@ var (
"DefaultTolerationSeconds",
"StorageObjectInUseProtection",
"Initializers",
"MutatingAdmissionWebhook",
"ValidatingAdmissionWebhook",
mutatingwebhook.PluginName,
validatingwebhook.PluginName,
"PodTolerationRestriction",
"AlwaysDeny",
// NOTE: ResourceQuota and ClusterResourceQuota must be the last 2 plugins.
Expand Down Expand Up @@ -155,8 +157,8 @@ var (
"DefaultTolerationSeconds",
"StorageObjectInUseProtection",
"Initializers",
"MutatingAdmissionWebhook",
"ValidatingAdmissionWebhook",
mutatingwebhook.PluginName,
validatingwebhook.PluginName,
"PodTolerationRestriction",
"AlwaysDeny",
// NOTE: ResourceQuota and ClusterResourceQuota must be the last 2 plugins.
Expand Down
6 changes: 5 additions & 1 deletion pkg/cmd/server/origin/admission/register.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
buildjenkinsbootstrapper "github.com/openshift/origin/pkg/build/apiserver/admission/jenkinsbootstrapper"
buildsecretinjector "github.com/openshift/origin/pkg/build/apiserver/admission/secretinjector"
buildstrategyrestrictions "github.com/openshift/origin/pkg/build/apiserver/admission/strategyrestrictions"
imagepolicy "github.com/openshift/origin/pkg/image/apiserver/admission/imagepolicy"
"github.com/openshift/origin/pkg/image/apiserver/admission/imagepolicy"
imageadmission "github.com/openshift/origin/pkg/image/apiserver/admission/limitrange"
ingressadmission "github.com/openshift/origin/pkg/network/apiserver/admission"
projectnodeenv "github.com/openshift/origin/pkg/project/apiserver/admission/nodeenv"
Expand All @@ -25,6 +25,8 @@ import (
quotarunonceduration "github.com/openshift/origin/pkg/quota/apiserver/admission/runonceduration"
schedulerpodnodeconstraints "github.com/openshift/origin/pkg/scheduler/admission/podnodeconstraints"
securityadmission "github.com/openshift/origin/pkg/security/apiserver/admission/sccadmission"
mutatingwebhook "k8s.io/apiserver/pkg/admission/plugin/webhook/mutating"
validatingwebhook "k8s.io/apiserver/pkg/admission/plugin/webhook/validating"

"k8s.io/kubernetes/plugin/pkg/admission/noderestriction"
expandpvcadmission "k8s.io/kubernetes/plugin/pkg/admission/storage/persistentvolume/resize"
Expand Down Expand Up @@ -99,6 +101,8 @@ var (
"ResourceQuota",
"openshift.io/ClusterResourceQuota",
"openshift.io/IngressAdmission",
mutatingwebhook.PluginName,
validatingwebhook.PluginName,
)

// DefaultOffPlugins includes plugins which require explicit configuration to run
Expand Down

0 comments on commit 9599d4c

Please sign in to comment.