make route strategy respect the full user

openshift · May 23, 2017 · 26cd8fd · 26cd8fd
1 parent 4c84232
commit 26cd8fd
Showing 1 changed file with 18 additions and 14 deletions.
diff --git a/pkg/route/registry/route/strategy.go b/pkg/route/registry/route/strategy.go
@@ -79,14 +79,16 @@ func (s routeStrategy) allocateHost(ctx apirequest.Context, route *api.Route) fi
 		}
 		res, err := s.sarClient.CreateSubjectAccessReview(
 			ctx,
-			&authorizationapi.SubjectAccessReview{
-				User: user.GetName(),
-				Action: authorizationapi.Action{
-					Verb:     "create",
-					Group:    api.GroupName,
-					Resource: "routes/custom-host",
+			authorizationapi.AddUserToSAR(
+				user,
+				&authorizationapi.SubjectAccessReview{
+					Action: authorizationapi.Action{
+						Verb:     "create",
+						Group:    api.GroupName,
+						Resource: "routes/custom-host",
+					},
 				},
-			},
+			),
 		)
 		if err != nil {
 			return field.ErrorList{field.InternalError(field.NewPath("spec", "host"), err)}
@@ -169,14 +171,16 @@ func (s routeStrategy) validateHostUpdate(ctx apirequest.Context, route, older *
 	}
 	res, err := s.sarClient.CreateSubjectAccessReview(
 		ctx,
-		&authorizationapi.SubjectAccessReview{
-			User: user.GetName(),
-			Action: authorizationapi.Action{
-				Verb:     "update",
-				Group:    "route.openshift.io",
-				Resource: "routes/custom-host",
+		authorizationapi.AddUserToSAR(
+			user,
+			&authorizationapi.SubjectAccessReview{
+				Action: authorizationapi.Action{
+					Verb:     "update",
+					Group:    "route.openshift.io",
+					Resource: "routes/custom-host",
+				},
 			},
-		},
+		),
 	)
 	if err != nil {
 		return field.ErrorList{field.InternalError(field.NewPath("spec", "host"), err)}